chore: Minor code refactor adhering to ES6 semantics#1122
Merged
ematipico merged 8 commits intowebpack:nextfrom Jan 18, 2020
Merged
chore: Minor code refactor adhering to ES6 semantics#1122ematipico merged 8 commits intowebpack:nextfrom
ematipico merged 8 commits intowebpack:nextfrom
Conversation
jamesgeorge007
force-pushed
the
chore/minor-code-refactor
branch
from
8276ddf to
d87119d
Compare
jamesgeorge007
force-pushed
the
chore/minor-code-refactor
branch
from
090810e to
123b2ef
Compare
hemal7735
reviewed
Nov 18, 2019
hemal7735
reviewed
Nov 18, 2019
Contributor
|
@jamesgeorge007 there are many test cases are failing. This could be due to the chain effect of not updating the test-cases based on the changes here. |
Member
Author
|
@hemal7735 couple of recent works in the |
evenstensberg
previously approved these changes
Nov 22, 2019
Member
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
lgtm, sending of to @ematipico
This was referenced Dec 7, 2019
jamesgeorge007
force-pushed
the
chore/minor-code-refactor
branch
from
3d6c24b to
a9c32ac
Compare
ematipico
previously approved these changes
Jan 17, 2020
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Member
|
@jamesgeorge007 have a look at #1141. There may be some duplicate changes here. |
rishabh3112
previously approved these changes
Jan 17, 2020
Member
rishabh3112
left a comment
rishabh3112
left a comment
There was a problem hiding this comment.
Looks good to me overall. Left a comment above.
anshumanv
previously approved these changes
Jan 17, 2020
jamesgeorge007
dismissed stale reviews from anshumanv, rishabh3112, and ematipico
via
c718411
jamesgeorge007
force-pushed
the
chore/minor-code-refactor
branch
from
c718411 to
02ac3f7
Compare
jamesgeorge007
changed the title
jamesgeorge007
changed the title
jamesgeorge007
force-pushed
the
chore/minor-code-refactor
branch
from
02ac3f7 to
6ac60d5
Compare
ematipico
approved these changes
Jan 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
N/A
Summary
Use object destructuring assignment wherever possible.
Does this PR introduce a breaking change?
Nope
Other information
N/A