chore(lib): refactored lib utils and groups#1140
Merged
ematipico merged 1 commit intowebpack:nextfrom Feb 10, 2020
Merged
Conversation
rishabh3112
reviewed
Dec 7, 2019
Member
rishabh3112
left a comment
rishabh3112
left a comment
There was a problem hiding this comment.
@pranshuchittora most changes looks good to me, I had a issue so left it below :)
jamesgeorge007
requested changes
Dec 7, 2019
ematipico
reviewed
Jan 20, 2020
ematipico
suggested changes
Jan 20, 2020
Contributor
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Could you please rebase and address my few comments? Than you!
pranshuchittora
force-pushed
the
refactor-cli-lib-grp-utils
branch
from
b5ad4a5 to
1acff22
Compare
webpack-bot
added
PR: review-outdated
PR: CI-ok
and removed
PR: conflict
PR: reviewed-changes-requested
labels
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
rishabh3112
requested changes
Feb 9, 2020
lib/utils/zero-config.js
Outdated
| if ((process.env.NODE_ENV && process.env.NODE_ENV === 'production') || process.env.NODE_ENV === 'development') { | ||
| return process.env.NODE_ENV; | ||
| const NODE_ENV = process.env.NODE_ENV; | ||
| if ((NODE_ENV && NODE_ENV === 'production') || NODE_ENV === 'development') { |
Member
There was a problem hiding this comment.
Suggested change
| if ((NODE_ENV && NODE_ENV === 'production') || NODE_ENV === 'development') { | |
| if (NODE_ENV && (NODE_ENV === 'production' || NODE_ENV === 'development')) { |
anshumanv
previously approved these changes
Feb 9, 2020
Member
anshumanv
left a comment
anshumanv
left a comment
There was a problem hiding this comment.
Looks like a good refactor.
ematipico
reviewed
Feb 9, 2020
jamesgeorge007
requested changes
Feb 9, 2020
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
@pranshuchittora Thanks for your update. I labeled the Pull Request so reviewers will review it again. @jamesgeorge007 Please review the new changes. |
chore: fixed the changes requested in the PR review chore: fixes from PR review
pranshuchittora
force-pushed
the
refactor-cli-lib-grp-utils
branch
from
5c501e5 to
afd37d4
Compare
jamesgeorge007
approved these changes
Feb 10, 2020
ematipico
approved these changes
Feb 10, 2020
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Other information