Merged
Conversation
jamesgeorge007
requested changes
Dec 7, 2019
Member
jamesgeorge007
left a comment
jamesgeorge007
left a comment
There was a problem hiding this comment.
I left a couple of comments.
Member
Author
|
@jamesgeorge007 awesome quick reviews 🐱👤👍 |
jamesgeorge007
requested changes
Dec 7, 2019
Comment on lines
+168
to
170
| const subject = allNames.filter(name => { | ||
| return args.includes(name); | ||
| })[0]; |
Member
There was a problem hiding this comment.
const subject = allNames.filter(name => args.includes(name))[0];Maybe 🤔
Contributor
There was a problem hiding this comment.
A little bit difficult to understand at first glance ...
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
Member
Author
|
I updated the help and added documentation links for some of those. |
ematipico
previously approved these changes
Jan 17, 2020
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Contributor
|
@rishabh3112 if you resolved the conflicts, I'd say we're ready to merge it! |
Member
Author
|
@ematipico rebased, and we are ready to go I think. |
ematipico
approved these changes
Jan 20, 2020
This was referenced Jan 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
No, will need
If relevant, did you update the documentation?
No
Summary
Adds help of flags as we have help for command from #1098.
Does this PR introduce a breaking change?
No
Other information
#1098 #1053