Merged
Conversation
ematipico
approved these changes
Dec 19, 2019
jamesgeorge007
approved these changes
Dec 20, 2019
anshumanv
approved these changes
Dec 21, 2019
wizardofhogwarts
approved these changes
Dec 23, 2019
Contributor
wizardofhogwarts
left a comment
wizardofhogwarts
left a comment
There was a problem hiding this comment.
@rishabh3112 looks good to me
jeffin143
approved these changes
Jan 16, 2020
|
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @jeffin143 Please review the new changes. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update Dependences
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
Some unnecessary dependencies were added to the beta release. Removed it based on feedback provided here webpack/webpack#9802 (comment)
Does this PR introduce a breaking change?
No
Other information