fix(create): handle create package errors gracefully#1159
Merged
rishabh3112 merged 4 commits intowebpack:nextfrom Jan 25, 2020
Merged
fix(create): handle create package errors gracefully#1159rishabh3112 merged 4 commits intowebpack:nextfrom
rishabh3112 merged 4 commits intowebpack:nextfrom
Conversation
rishabh3112
requested changes
Dec 29, 2019
Member
rishabh3112
left a comment
rishabh3112
left a comment
There was a problem hiding this comment.
Looks good to me. Left a suggestion.
webpack-bot
added
PR: reviewed-changes-requested
PR: review-outdated
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
handle package creation errors ISSUES CLOSED: webpack#1151
update create package err message ISSUES CLOSED: webpack#1151
update comment to something ISSUES CLOSED: webpack#1151
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
jamesgeorge007
requested changes
Jan 20, 2020
Member
jamesgeorge007
left a comment
jamesgeorge007
left a comment
There was a problem hiding this comment.
Left couple of comments.
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
update err message and exit code ISSUES CLOSED: webpack#1151
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @jamesgeorge007 Please review the new changes. |
rishabh3112
approved these changes
Jan 25, 2020
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle package creation errors
ISSUES CLOSED: #1151
What kind of change does this PR introduce?
handle create package errors when
Did you add tests for your changes?
No, will add tests separately
If relevant, did you update the documentation?
NA
Summary
Handle package creation errs when working in a package dir
Does this PR introduce a breaking change?
No
Other information