Merged
Conversation
ematipico
force-pushed
the
feature/better-logger
branch
from
354c1f2 to
936f62b
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
rishabh3112
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Chores
Did you add tests for your changes?
No, not needed
If relevant, did you update the documentation?
No
Summary
I moved the creation of the logger inside a different file and imported it everywhere we log something
I don't think it's a good practice to pollute the process object.
Does this PR introduce a breaking change?
Nope
Other information