docs: Updated information regarding migrate command and a typo fix#1187
Merged
rishabh3112 merged 3 commits intowebpack:nextfrom Feb 5, 2020
Merged
docs: Updated information regarding migrate command and a typo fix#1187rishabh3112 merged 3 commits intowebpack:nextfrom
rishabh3112 merged 3 commits intowebpack:nextfrom
Conversation
jamesgeorge007
force-pushed
the
docs/contributing
branch
from
72fc6eb to
4afa0ec
Compare
jamesgeorge007
force-pushed
the
docs/contributing
branch
from
7028524 to
e9defa2
Compare
rishabh3112
previously approved these changes
Jan 27, 2020
anshumanv
previously approved these changes
Jan 27, 2020
Contributor
|
@jamesgeorge007 please open just one PR with all the changes, it's better for overviewing all together the changes. It's up to you if leave open this one or #1189. |
jamesgeorge007
dismissed stale reviews from anshumanv and rishabh3112
via
9a29d82
jamesgeorge007
requested review from
ematipico and
rishabh3112
and removed request for
ematipico
rishabh3112
requested changes
Feb 1, 2020
Member
rishabh3112
left a comment
rishabh3112
left a comment
There was a problem hiding this comment.
Please update PR title to match the changes now.
jamesgeorge007
changed the title
ematipico
approved these changes
Feb 4, 2020
|
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
webpack-bot
added
PR: CI-ok
and removed
PR: reviewed-changes-requested
PR: CI-not-ok
labels
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
docs update.
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
Yes
Summary
migrateisn't a flag anymore. This hasn't been updated for a long time.Does this PR introduce a breaking change?
Nope
Other information
N/A