chore: it restores inquirer for prompting external commands by ematipico · Pull Request #1201 · webpack/webpack-cli

ematipico · 2020-02-03T13:40:03Z

What kind of change does this PR introduce?

Fixes #1200

Did you add tests for your changes?
Not needed

If relevant, did you update the documentation?
Not for now

Summary
A fix for the bug was already there but we have uncomment the code and make a new release

Does this PR introduce a breaking change?

No

Other information

lib/commands/external.js

Co-Authored-By: James George <jamesgeorge998001@gmail.com>

webpack-bot · 2020-02-04T08:25:51Z

@ematipico Please review the following output log for errors:

Worker information [...]
Build system information [...]
travis_fold:start:docker_mtu
travis_fold:end:docker_mtu
travis_fold:start:resolvconf
travis_fold:end:resolvconf


Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

Setting environment variables from repository settings
$ export nproc=4

Setting environment variables from .travis.yml
$ export JOB_PART=integration


Setting up build cache [...]
 [...]
$ node --version
v12.14.1
$ npm --version
6.13.4
$ nvm --version
0.35.2

$ npm run travis:lint

> webpack-cli@4.0.0-beta.1 travis:lint /home/travis/build/webpack/webpack-cli
> npm run build && npm run lint


> webpack-cli@4.0.0-beta.1 build /home/travis/build/webpack/webpack-cli
> tsc


> webpack-cli@4.0.0-beta.1 lint /home/travis/build/webpack/webpack-cli
> eslint . --ext .js,.ts

The command "npm run travis:lint" exited with 0.
$ npm run test:ci

> webpack-cli@4.0.0-beta.1 test:ci /home/travis/build/webpack/webpack-cli
> npm run test:cli && npm run test:packages


> webpack-cli@4.0.0-beta.1 test:cli /home/travis/build/webpack/webpack-cli
> nyc jest test/ --maxWorkers=4 --reporters=default --reporters=jest-junit

 PASS  test/utils/test-utils.test.js
 PASS  test/node/node.test.js (10.588s)
 PASS  test/version/version-multi-args.test.js (11.05s)
 PASS  test/output/named-bundles/output-named-bundles.test.js (17.652s)
 PASS  test/help/help-single-arg.test.js (8.909s)
 PASS  test/entry/defaults-index/entry-multi-args.test.js (6.468s)
 PASS  test/global/global.test.js (27.957s)
 PASS  test/output/defaults/output-defaults.test.js (6.717s)
 PASS  test/info/info-basic.test.js (19.893s)
 PASS  test/config-lookup/dotfolder-array/dotfolder-array.test.js
 PASS  test/config/type/array/array-config.test.js
 PASS  test/source-map/object/source-map-object.test.js (9.881s)
 PASS  test/config/basic/basic-config.test.js
 PASS  test/serve/serve-basic.test.js (26.164s)
 PASS  test/help/help-commands.test.js (5.876s)
 PASS  test/help/help-flags.test.js (6.455s)
 PASS  test/merge/defaults/merge-defaults.test.js (5.726s)
 PASS  test/config/type/function/function-config.test.js
 PASS  test/json/json.test.js
 PASS  test/help/help-multi-args.test.js (6.199s)
 PASS  test/config-lookup/dotfolder-single/dotfolder-single.test.js
 PASS  test/env/array/array-env.test.js (9.481s)
 PASS  test/source-map/array/source-map-array.test.js (6.395s)
 PASS  test/config/empty/empty-config.test.js
 PASS  test/entry/defaults-empty/entry-single-arg.test.js
ts-jest[versions] (WARN) Version 25.1.0 of jest installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=24.0.0 <25.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
 PASS  test/env/object/object-env.test.js (6.841s)
 PASS  test/merge/config/merge-config.test.js
 PASS  test/version/version-single-arg.test.js
 PASS  test/target/node/node-test.test.js
 PASS  test/output/pretty/pretty.test.js
 PASS  test/serve/args-to-camel-case.test.js (5.095s)
�[999D�[K
Test Suites: 1 skipped, 31 passed, 31 of 32 total
Tests:       1 skipped, 73 passed, 74 total
Snapshots:   1 passed, 1 total
Time:        63.014s
Ran all test suites matching /test\//i.

> webpack-cli@4.0.0-beta.1 test:packages /home/travis/build/webpack/webpack-cli
> nyc jest packages/ --maxWorkers=4 --reporters=default --reporters=jest-junit

ts-jest[versions] (WARN) Version 25.1.0 of jest installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=24.0.0 <25.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
ts-jest[versions] (WARN) Version 25.1.0 of jest installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=24.0.0 <25.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
ts-jest[versions] (WARN) Version 25.1.0 of jest installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=24.0.0 <25.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
ts-jest[versions] (WARN) Version 25.1.0 of jest installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=24.0.0 <25.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
 PASS  packages/utils/__tests__/resolve-packages.test.ts (10.85s)
 PASS  packages/utils/__tests__/package-manager.test.ts (12.615s)
 PASS  packages/webpack-scaffold/__tests__/index.test.ts (12.812s)
 PASS  packages/utils/__tests__/validate-identifier.test.ts
 PASS  packages/info/__tests__/index.test.ts
 PASS  packages/utils/__tests__/ast-utils.test.ts (15.902s)
 PASS  packages/utils/__tests__/recursive-parser.test.ts
 PASS  packages/migrate/commonsChunkPlugin/__tests__/commonsChunkPlugin.test.ts
 PASS  packages/migrate/__tests__/migrate.test.ts (5.928s)
 PASS  packages/utils/__tests__/is-local-path.test.ts
 PASS  packages/migrate/loaders/__tests__/loaders.test.ts

Please remove deprecated plugins manually. 
See https://webpack.js.org/guides/migrating/ for more information.
Please remove deprecated plugins manually. 
See https://webpack.js.org/guides/migrating/ for more information.
Please remove deprecated plugins manually. 
See https://webpack.js.org/guides/migrating/ for more information. PASS  packages/migrate/removeDeprecatedPlugins/__tests__/removeDeprecatedPlugins.test.ts
 PASS  packages/generators/__tests__/add-generator.test.ts
 PASS  packages/utils/__tests__/npm-packages-exists.test.ts (5.429s)

ℹ INFO  For more information and a detailed description of each question, have a look at: https://github.com/webpack/webpack-cli/blob/master/INIT.md
ℹ INFO  Alternatively, run "webpack(-cli) --help" for usage info

 PASS  packages/migrate/uglifyJsPlugin/__tests__/uglifyJsPlugin.test.ts
 PASS  packages/migrate/loaderOptionsPlugin/__tests__/loaderOptionsPlugin.test.ts
 PASS  packages/generators/__tests__/loader-generator.test.ts
 FAIL  packages/generators/__tests__/init-generator.test.ts (9.202s)
  ● init generator › generates a webpack project config

    : Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Error:

      3 | 
      4 | describe('init generator', () => {
    > 5 |     it('generates a webpack project config', async () => {
        |     ^
      6 |         const outputDir = await run(join(__dirname, '../init-generator')).withPrompts({
      7 |             multiEntries: false,
      8 |             singularEntry: 'src/index2',

      at new Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
      at Suite.<anonymous> (packages/generators/__tests__/init-generator.test.ts:5:5)

 PASS  packages/utils/__tests__/npm-exists.test.ts
 PASS  packages/migrate/removeJsonLoader/__tests__/removeJsonLoader.test.ts
 PASS  packages/migrate/moduleConcatenationPlugin/__tests__/moduleConcatenationPlugin.test.ts
 PASS  packages/migrate/namedModulesPlugin/__tests__/namedModulesPlugin.test.ts
 PASS  packages/migrate/noEmitOnErrorsPlugin/__tests__/noEmitOnErrorsPlugin.test.ts
 PASS  packages/migrate/bannerPlugin/__tests__/bannerPlugin.test.ts
 PASS  packages/migrate/extractTextPlugin/__tests__/extractTextPlugin.test.ts
 PASS  packages/migrate/resolve/__tests__/resolve.test.ts
 PASS  packages/migrate/outputPath/__tests__/outputPath.test.ts
�[999D�[K
Summary of all failing tests
 FAIL  packages/generators/__tests__/init-generator.test.ts (9.202s)
  ● init generator › generates a webpack project config

    : Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Error:

      3 | 
      4 | describe('init generator', () => {
    > 5 |     it('generates a webpack project config', async () => {
        |     ^
      6 |         const outputDir = await run(join(__dirname, '../init-generator')).withPrompts({
      7 |             multiEntries: false,
      8 |             singularEntry: 'src/index2',

      at new Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
      at Suite.<anonymous> (packages/generators/__tests__/init-generator.test.ts:5:5)


Test Suites: 1 failed, 26 passed, 27 total
Tests:       1 failed, 144 passed, 145 total
Snapshots:   95 passed, 95 total
Time:        29.894s
Ran all test suites matching /packages\//i.


The command "npm run test:ci" exited with 1.
store build cache [...]

Done. Your build exited with 1.

See complete report here.

rishabh3112

Should we increase timeout for init-generator test? It has been failing CI for quite some time.

ematipico · 2020-02-06T11:59:33Z

Maybe later. For now we skipped it.

rishabh3112 · 2020-02-07T14:58:56Z

Lets merge it when CI passes

anshumanv

lgtm

lib/commands/external.js

chore: it restores inquirer for prompting external commands

b2120f8

ematipico requested a review from a team as a code owner February 3, 2020 13:40

webpack-bot added PR: unreviewed PR: CI-not-ok labels Feb 3, 2020

jamesgeorge007 reviewed Feb 3, 2020

View reviewed changes

lib/commands/external.js Outdated Show resolved Hide resolved

chore: update lib/commands/external.js

1fc7e0d

Co-Authored-By: James George <jamesgeorge998001@gmail.com>

rishabh3112 reviewed Feb 5, 2020

View reviewed changes

anshumanv mentioned this pull request Feb 6, 2020

[create]: Unable to invoke create package #1208

Closed

ematipico requested review from jamesgeorge007 and rishabh3112 February 7, 2020 13:44

chore: rebase

7bcb783

rishabh3112 approved these changes Feb 7, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: unreviewed labels Feb 7, 2020

anshumanv approved these changes Feb 7, 2020

View reviewed changes

jamesgeorge007 reviewed Feb 7, 2020

View reviewed changes

lib/commands/external.js Show resolved Hide resolved

ematipico merged commit 70c04ea into webpack:next Feb 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: it restores inquirer for prompting external commands#1201

chore: it restores inquirer for prompting external commands#1201
ematipico merged 3 commits intowebpack:nextfrom
ematipico:bugfix/reintroduce-inquirer

ematipico commented Feb 3, 2020

Uh oh!

Uh oh!

webpack-bot commented Feb 4, 2020

Uh oh!

rishabh3112 left a comment

Uh oh!

ematipico commented Feb 6, 2020

Uh oh!

rishabh3112 commented Feb 7, 2020

Uh oh!

anshumanv left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

ematipico commented Feb 3, 2020

Uh oh!

Uh oh!

webpack-bot commented Feb 4, 2020

Uh oh!

rishabh3112 left a comment

Choose a reason for hiding this comment

Uh oh!

ematipico commented Feb 6, 2020

Uh oh!

rishabh3112 commented Feb 7, 2020

Uh oh!

anshumanv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants