Skip to content

feat: adds standard output flag#1206

Merged
ematipico merged 4 commits intowebpack:nextfrom
rishabh3112:feat/standard-output
Feb 8, 2020
Merged

feat: adds standard output flag#1206
ematipico merged 4 commits intowebpack:nextfrom
rishabh3112:feat/standard-output

Conversation

@rishabh3112
Copy link
Copy Markdown
Member

@rishabh3112 rishabh3112 commented Feb 6, 2020

What kind of change does this PR introduce?
feature.
It adds another flag standard which produce standard result

Did you add tests for your changes?
Yes.

If relevant, did you update the documentation?
No.

Summary
--standard outputs result of stats.toString()

Does this PR introduce a breaking change?
N/A

Other information
No

@rishabh3112 rishabh3112 requested a review from a team as a code owner February 6, 2020 11:25
@rishabh3112 rishabh3112 changed the title Feat/standard output feat: adds standard output flag Feb 6, 2020
@rishabh3112
Copy link
Copy Markdown
Member Author

rishabh3112 commented Feb 6, 2020

Current behavior
image

@webpack-bot
Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

anshumanv
anshumanv previously approved these changes Feb 6, 2020
Copy link
Copy Markdown
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice

Copy link
Copy Markdown
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a test please?

Copy link
Copy Markdown
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Having a test case would be a great addition.

@webpack-bot
Copy link
Copy Markdown

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

@rishabh3112 rishabh3112 requested a review from ematipico February 7, 2020 15:01
@ematipico ematipico merged commit b05e5eb into webpack:next Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants