feat: allow using cjs as default config#1775
Merged
anshumanv merged 3 commits intowebpack:nextfrom Aug 28, 2020
Merged
Conversation
alexander-akait
previously approved these changes
Aug 27, 2020
Member
Author
|
CI freeze 😞 |
alexander-akait
approved these changes
Aug 28, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
/cc @webpack/cli-team
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @snitin315 Please review the new changes. |
jamesgeorge007
approved these changes
Aug 28, 2020
evenstensberg
approved these changes
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1165
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No need
Summary
Does this PR introduce a breaking change?
No
Other information
Refer discussion in #1165