fix: mode behaviour

[anshumanv]

What kind of change does this PR introduce?

fix

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Yes

Summary
Fix mode priority

• mode form flag
• config
• NODE_ENV

Does this PR introduce a breaking change?
Nay

Other information

[alexander-akait]

No need this, webpack do it itself (default is production)

[anshumanv]

gotcha

[anshumanv]

Need this because #1678 hence added

[alexander-akait]

Okay, let's refactor it in future

[anshumanv]

Sure sure

[alexander-akait]

Also can you add multicompiler tests

[anshumanv]

Also can you add multicompiler tests

-c 1.js -c 2.js

which config mode should be priority? @evilebottnawi

[alexander-akait]

With --mode=production both configurations should set mode: production, without --mode=production but with mode: 'production' in config should keep values, with NODE_ENV and without mode: 'production' should use NODE_ENV, same logic, maybe better to use module: development to test, because default value is production

[anshumanv]

With --mode=production both configurations should set mode: production, without --mode=production but with mode: 'production' in config should keep values, with NODE_ENV and without mode: 'production' should use NODE_ENV, same logic, maybe better to use module: development to test, because default value is production

Needed more work than I thought, looks good now

[webpack-bot]

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.