Merged
Conversation
anshumanv
reviewed
Oct 14, 2020
Member
anshumanv
left a comment
anshumanv
left a comment
There was a problem hiding this comment.
Some comments, mostly looks good
test/colors/colors.test.js
Outdated
| }); | ||
|
|
||
| it('should work with the "stats" option from the configuration', () => { | ||
| const { stderr, stdout, exitCode } = run(__dirname, [`--config=${resolve(__dirname, './stats-string.webpack.config.js')}`]); |
Member
There was a problem hiding this comment.
can give relative path,
Suggested change
| const { stderr, stdout, exitCode } = run(__dirname, [`--config=${resolve(__dirname, './stats-string.webpack.config.js')}`]); | |
| const { stderr, stdout, exitCode } = run(__dirname, ['-c', './stats-string.webpack.config.js']); |
Member
Author
There was a problem hiding this comment.
No need to use aliases in tests, except tests on aliases, we can rename them (this can happen more often than renaming basic options)
| expect(exitCode).toBe(0); | ||
| }); | ||
|
|
||
| it('should work with the "stats" option from the configuration #4', () => { |
Member
There was a problem hiding this comment.
Can we also add tests with both config and flags?
Member
Author
There was a problem hiding this comment.
Feel free to do it after this will be merged, I really don't have time to solve all problems from previously webpack-cli contrbutors, I'm very disappointed, I want to fix basic regressions and rewrite most of code, because here bug on almost every line of code
Member
Author
|
We need more tests, put it in TODO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
No need
Summary
fixes #1915
Does this PR introduce a breaking change?
No
Other information
No