feat: respect the infrastructureLogging.level option#2144
Merged
alexander-akait merged 6 commits intomasterfrom Dec 1, 2020
Merged
feat: respect the infrastructureLogging.level option#2144alexander-akait merged 6 commits intomasterfrom
infrastructureLogging.level option#2144alexander-akait merged 6 commits intomasterfrom
Conversation
Member
Author
|
/cc @piecyk something missed? |
Member
Author
|
Need a lot of changes in tests 😞 WIP |
Contributor
Yep, that's why the #2036 pr had so many changes. |
10c544b to
a322e0f
Compare
Member
Author
|
/cc @snitin315 we need more tests refactor:
you can help me with this |
Member
|
Yes I can help. Should I do it in this PR or separate? |
Member
Author
|
snitin315
previously approved these changes
Nov 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #2144 +/- ##
==========================================
+ Coverage 66.15% 68.43% +2.27%
==========================================
Files 72 72
Lines 2340 2341 +1
Branches 516 516
==========================================
+ Hits 1548 1602 +54
+ Misses 792 739 -53
Continue to review full report at Codecov.
|
Member
Author
|
Hata macos and watching, we really need to stability this tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
No change existing, WIP
If relevant, did you update the documentation?
No
Summary
fixes #2019
Does this PR introduce a breaking change?
No, it is feature
Other information
No