Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2388 +/- ##
==========================================
+ Coverage 71.74% 71.79% +0.05%
==========================================
Files 47 47
Lines 2173 2177 +4
Branches 573 574 +1
==========================================
+ Hits 1559 1563 +4
Misses 614 614
Continue to review full report at Codecov.
|
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Also need tests, anyway looks good
Member
|
@snitin315 let's finish, I want to do release, it is very high requested feature |
Member
Author
|
Need to fix CI, debugging. |
snitin315
force-pushed
the
feat/node-env
branch
from
b811c54 to
4f57552
Compare
snitin315
force-pushed
the
feat/node-env
branch
from
4f57552 to
2d9dd01
Compare
alexander-akait
previously approved these changes
Feb 2, 2021
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Let's convert from draft
Member
|
I will add some complex tests |
Member
Author
|
💯 |
Member
|
Thanks |
This was referenced Mar 11, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
YES WIP
If relevant, did you update the documentation?
YES
Summary
fixes #2362
Does this PR introduce a breaking change?
NO
Other information