Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2482 +/- ##
==========================================
+ Coverage 71.86% 71.91% +0.05%
==========================================
Files 46 46
Lines 2182 2186 +4
Branches 581 583 +2
==========================================
+ Hits 1568 1572 +4
Misses 614 614
Continue to review full report at Codecov.
|
Member
Author
|
Hard to test 😞, WIP. |
Member
Should be a simple smoketest, I am testing now and will send commits to this PR. |
Member
Done. |
Member
Author
Thanks 🚀 |
alexander-akait
approved these changes
Mar 9, 2021
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
WIP on tests
If relevant, did you update the documentation?
No
Summary
Fixes #2479
Does this PR introduce a breaking change?
No
Other information
No