fix: not found module after ask installation#2761
Merged
alexander-akait merged 2 commits intomasterfrom Jun 5, 2021
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Hard to add, manually tested
If relevant, did you update the documentation?
No need
Summary
fixes #2716
Does this PR introduce a breaking change?
No
Other information
@webpack/cli-team
webpack-dev-serverandwebpackitself, just replacerequire.resolveon this functionpromptInstallationshould not return something, only install package