Improve & extend vitest args handling

Author: webpro

packages/knip/fixtures/plugins/vitest/package.json

@@ -2,7 +2,13 @@
   "name": "@plugins/vitest",
   "scripts": {
     "test": "vitest --config vitest-default-coverage.config.ts",
-    "test:ui": "vitest --ui"
+    "test:ui": "vitest --ui",
+    "test:coverage": "vitest --coverage.provider istanbul",
+    "test:reporter": "vitest --reporter vitest-sonar-reporter",
+    "test:reporter:builtin": "vitest --reporter verbose",
+    "test:env": "vitest --environment jsdom",
+    "test:typecheck": "vitest --typecheck.checker vue-tsc",
+    "test:typecheck:tsc": "vitest --typecheck.checker tsc"
   },
   "devDependencies": {
     "vitest": "*",

packages/knip/src/plugins/vitest/index.ts

@@ -2,7 +2,6 @@ import type { ParsedArgs } from 'minimist';
 import { DEFAULT_EXTENSIONS } from '../../constants.js';
 import type { Args } from '../../types/args.js';
 import type { IsPluginEnabled, Plugin, PluginOptions, ResolveConfig } from '../../types/config.js';
-import type { PackageJson } from '../../types/package-json.js';
 import { _glob } from '../../util/glob.js';
 import { type Input, toAlias, toConfig, toDeferResolve, toDependency, toEntry } from '../../util/input.js';
 import { isAbsolute, isInternal, join, toPosix } from '../../util/path.js';
@@ -24,13 +23,8 @@ const mocks = ['**/__mocks__/**/*.[jt]s?(x)'];
 
 const entry = ['**/*.{bench,test,test-d,spec}.?(c|m)[jt]s?(x)', ...mocks];
 
-const isVitestCoverageCommand = /vitest(.+)--coverage(?:\.enabled(?:=true)?)?/;
-
-const hasScriptWithCoverage = (scripts: PackageJson['scripts']) =>
-  scripts ? Object.values(scripts).some(script => isVitestCoverageCommand.test(script)) : false;
-
 const findConfigDependencies = (localConfig: ViteConfig, options: PluginOptions, vitestRoot: string) => {
-  const { manifest, configFileDir: dir } = options;
+  const { configFileDir: dir } = options;
   const testConfig = localConfig.test;
 
   if (!testConfig) return [];
@@ -44,8 +38,7 @@ const findConfigDependencies = (localConfig: ViteConfig, options: PluginOptions,
       : [];
   const reporters = getExternalReporters(testConfig.reporters);
 
-  const hasCoverageEnabled =
-    (testConfig.coverage && testConfig.coverage.enabled !== false) || hasScriptWithCoverage(manifest.scripts);
+  const hasCoverageEnabled = testConfig.coverage && testConfig.coverage.enabled !== false;
   const coverage = hasCoverageEnabled ? [`@vitest/coverage-${testConfig.coverage?.provider ?? 'v8'}`] : [];
 
   const setupFiles = [testConfig.setupFiles ?? []].flat().map(specifier => ({ ...toDeferResolve(specifier), dir: vitestRoot }));
@@ -192,6 +185,21 @@ const args: Args = {
   resolveInputs: (parsed: ParsedArgs) => {
     const inputs: Input[] = [];
     if (parsed['ui']) inputs.push(toDependency('@vitest/ui', { optional: true }));
+    if (parsed['coverage']) {
+      const provider = typeof parsed['coverage'] === 'object' ? parsed['coverage'].provider : undefined;
+      inputs.push(toDependency(`@vitest/coverage-${provider ?? 'v8'}`));
+    }
+    if (parsed['reporter']) {
+      for (const reporter of getExternalReporters([parsed['reporter']].flat())) {
+        inputs.push(toDependency(reporter));
+      }
+    }
+    if (parsed['environment'] && parsed['environment'] !== 'node') {
+      inputs.push(toDependency(getEnvSpecifier(parsed['environment'])));
+    }
+    if (typeof parsed['typecheck'] === 'object' && parsed['typecheck'].checker) {
+      inputs.push(toDependency(parsed['typecheck'].checker === 'tsc' ? 'typescript' : parsed['typecheck'].checker));
+    }
     return inputs;
   },
 };

packages/knip/test/plugins/vitest-npm-script.test.ts

@@ -12,7 +12,7 @@ test('Find dependencies with the Vitest plugin', async () => {
   const { issues, counters } = await main(options);
 
   assert(issues.devDependencies['package.json']['vitest']);
-  assert(issues.unlisted['vitest.config.ts']['@vitest/coverage-v8']);
+  assert(issues.unlisted['package.json']['@vitest/coverage-v8']);
   assert(issues.binaries['package.json']['vitest']);
 
   assert.deepEqual(counters, {

packages/knip/test/plugins/vitest.test.ts

@@ -19,11 +19,15 @@ test('Find dependencies with the Vitest plugin', async () => {
   assert(issues.unlisted['vitest-default-coverage.config.ts']['@vitest/coverage-v8']);
   assert(issues.unlisted['vitest.config.ts']['happy-dom']);
   assert(issues.unlisted['vitest.config.ts']['@vitest/coverage-istanbul']);
+  assert(issues.unlisted['package.json']['@vitest/coverage-istanbul']);
+  assert(issues.unlisted['package.json']['vitest-sonar-reporter']);
+  assert(issues.unlisted['package.json']['jsdom']);
+  assert(issues.unlisted['package.json']['vue-tsc']);
   assert(issues.unresolved['vitest.config.ts']['setup.js']);
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    unlisted: 7,
+    unlisted: 11,
     unresolved: 1,
     processed: 9,
     total: 9,