Fix agent modal scrolling and add edit functionality#264
Closed
90stm wants to merge 2 commits intowinfunc:mainfrom
Closed
Fix agent modal scrolling and add edit functionality#26490stm wants to merge 2 commits intowinfunc:mainfrom
90stm wants to merge 2 commits intowinfunc:mainfrom
Conversation
- Changed overflow-hidden to min-h-0 in AgentsModal to enable proper scrolling - Added max-h constraint and overflow-y-scroll to agent list container - Removed conflicting height constraints that prevented scrolling - Now all agents are visible with proper scrollbar functionality Fixes issue where users couldn't see all their agents in the modal
- Added Edit button to each agent in the Agent Management modal - Implemented event system to pass agent data to CreateAgent component - Modified CreateAgent to accept editing data from localStorage - Added proper cleanup of localStorage after editing Closes #259 - Users can now edit existing agents
Member
|
@claude please review this |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Member
|
@claude please review this |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Member
|
Hi, thanks for the PR. I just ran it through claude. Can you take a look at these suggestions?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues with the Agent Management modal:
Changes Made
1. Fixed Agent Modal Scrolling
ScrollAreacomponent with nativeoverflow-y-scrollinAgentsModal.tsxoverflow-hiddentomin-h-0to allow proper scrollingmax-h-[400px]constraint to ensure scrollbar appears2. Added Edit Functionality
Testing