Fix missing installation_type field in ClaudeInstallation struct#374
Merged
123vivekr merged 1 commit intowinfunc:mainfrom Oct 10, 2025
Merged
Conversation
- Add missing installation_type field to ClaudeInstallation initialization in find_nvm_installations() function at line 222 - This field is required by the struct definition but was omitted from one instance in the NVM discovery code - The missing field caused Rust compilation to fail with error E0063 during tauri build - Set installation_type to InstallationType::System to match other NVM installations in the same function - Fixes build failure for aarch64-apple-darwin target and other platforms
davutg
approved these changes
Sep 28, 2025
davutg
left a comment
There was a problem hiding this comment.
I have done the same and issue is fixed for me.
rluethy
approved these changes
Oct 2, 2025
rluethy
left a comment
There was a problem hiding this comment.
The proposed change fixed the build error.
|
I did the same fix and successfully built the Windows executable |
Member
|
Thanks! Merged 🙌 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a compilation error in the Rust code that was preventing successful builds of the Tauri application.
Problem
The build was failing with the following error:
Root Cause
In the
find_nvm_installations()function at line 222, one instance ofClaudeInstallationstruct initialization was missing the requiredinstallation_typefield. This field was added to the struct definition but this particular initialization was not updated.Solution
installation_type: InstallationType::Systemfield to theClaudeInstallationinitializationTesting
aarch64-apple-darwintargetClaudeInstallationinitializations in the codebaseFiles Changed
src-tauri/src/claude_binary.rs- Added missinginstallation_typefieldThis is a minimal, targeted fix that resolves the immediate build issue while maintaining code consistency.