Skip to content

chore: Add DX as Codeowners#335

Merged
gjtorikian merged 2 commits intomainfrom
add-dx-codeowners
Mar 5, 2026
Merged

chore: Add DX as Codeowners#335
gjtorikian merged 2 commits intomainfrom
add-dx-codeowners

Conversation

@workos-sdk-automation
Copy link
Contributor

Summary

  • Adds @workos/dx team as code owners for the repository

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@workos-sdk-automation workos-sdk-automation bot requested a review from a team as a code owner March 5, 2026 20:30
@workos-sdk-automation workos-sdk-automation bot requested a review from nicknisi March 5, 2026 20:30
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 5, 2026

Greptile Summary

This PR adds @workos/dx as a code owner for the workos-php repository by appending a new * @workos/dx rule to .github/CODEOWNERS. However, due to GitHub's last-match-wins CODEOWNERS precedence, the new rule unintentionally overrides the existing * @workos/php rule, effectively removing the PHP team as a required reviewer.

Key Finding: The two separate * glob rules result in only @workos/dx being required for reviews — @workos/php is silently dropped. Both teams should be combined onto a single line (* @workos/php @workos/dx) to require reviews from both.

Confidence Score: 2/5

  • The PR has a logic issue where the new rule unintentionally removes the PHP team as a required reviewer due to CODEOWNERS' last-match-wins precedence.
  • The PR introduces a functional issue with code ownership governance. While the change itself is a simple configuration edit, the last-match-wins behavior of GitHub's CODEOWNERS file means that adding a second * rule silently overrides the first, removing @workos/php as a required reviewer. This is likely unintended and should be corrected before merging. The fix is straightforward (combine both teams on one line), but the issue needs to be addressed.
  • .github/CODEOWNERS — the duplicate * glob needs to be consolidated onto a single line.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["PR opened on workos-php"] --> B["GitHub evaluates CODEOWNERS"]
    B --> C["Rule 1: * @workos/php"]
    C --> D["Rule 2: * @workos/dx  ← last match wins"]
    D --> E["Required reviewer: @workos/dx ONLY"]
    E --> F["@workos/php silently dropped ⚠️"]

    style F fill:#f88,stroke:#c00,color:#000
    style D fill:#ffa,stroke:#aa0,color:#000
Loading

Last reviewed commit: 2d1f497

Comment on lines +4 to +7
* @workos/php

# DX Team
* @workos/dx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub's CODEOWNERS file uses a last-match-wins strategy — the last matching pattern takes precedence over earlier ones. By adding a second * @workos/dx rule, the @workos/php team is effectively removed as a required reviewer for all files, because @workos/dx now matches last.

If the intent is to require both teams to review, both owners should be listed on the same line:

Suggested change
* @workos/php
# DX Team
* @workos/dx
* @workos/php @workos/dx

Reference: GitHub docs on CODEOWNERS

@gjtorikian gjtorikian changed the title Add DX as Codeowners chore: Add DX as Codeowners Mar 5, 2026
@gjtorikian gjtorikian merged commit 5317c50 into main Mar 5, 2026
7 checks passed
@gjtorikian gjtorikian deleted the add-dx-codeowners branch March 5, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants