Optimize alignment lookup and validation

- Extract getColumnAlignment() method for better readability
- Use array_flip() for O(1) lookups instead of in_array() O(n) searches
- Address code review feedback

Co-authored-by: swissspidy <[email protected]>

Author: Copilot

lib/cli/Table.php

@@ -217,14 +217,17 @@ public function setFooters(array $footers) {
 	 * @param array  $alignments  An array of alignment constants keyed by column name.
 	 */
 	public function setAlignments(array $alignments) {
-		$valid_alignments = array( Column::ALIGN_LEFT, Column::ALIGN_RIGHT, Column::ALIGN_CENTER );
+		$valid_alignments = array_flip( array( Column::ALIGN_LEFT, Column::ALIGN_RIGHT, Column::ALIGN_CENTER ) );
 		foreach ( $alignments as $column => $alignment ) {
-			if ( ! in_array( $alignment, $valid_alignments, true ) ) {
+			if ( ! isset( $valid_alignments[ $alignment ] ) ) {
 				throw new \InvalidArgumentException( "Invalid alignment value '$alignment' for column '$column'." );
 			}
 			// Only validate column names if headers are already set
-			if ( ! empty( $this->_headers ) && ! in_array( $column, $this->_headers, true ) ) {
-				throw new \InvalidArgumentException( "Column '$column' does not exist in table headers." );
+			if ( ! empty( $this->_headers ) ) {
+				$headers_map = array_flip( $this->_headers );
+				if ( ! isset( $headers_map[ $column ] ) ) {
+					throw new \InvalidArgumentException( "Column '$column' does not exist in table headers." );
+				}
 			}
 		}
 		$this->_alignments = $alignments;

lib/cli/table/Ascii.php

@@ -197,9 +197,22 @@ public function row( array $row ) {
 		return $ret;
 	}
 
+	/**
+	 * Get the alignment for a column.
+	 *
+	 * @param int $column Column index.
+	 * @return int Alignment constant (STR_PAD_LEFT, STR_PAD_RIGHT, or STR_PAD_BOTH).
+	 */
+	private function getColumnAlignment( $column ) {
+		$column_name = isset( $this->_headers[ $column ] ) ? $this->_headers[ $column ] : '';
+		if ( $column_name !== '' && array_key_exists( $column_name, $this->_alignments ) ) {
+			return $this->_alignments[ $column_name ];
+		}
+		return Column::ALIGN_LEFT;
+	}
+
 	private function padColumn($content, $column) {
-		$column_name = isset( $this->_headers[$column] ) ? $this->_headers[$column] : '';
-		$alignment = ( $column_name !== '' && array_key_exists( $column_name, $this->_alignments ) ) ? $this->_alignments[$column_name] : Column::ALIGN_LEFT;
+		$alignment = $this->getColumnAlignment( $column );
 		$content = str_replace( "\t", '    ', (string) $content );
 		return $this->_characters['padding'] . Colors::pad( $content, $this->_widths[ $column ], $this->isPreColorized( $column ), false, $alignment ) . $this->_characters['padding'];
 	}