Updated login form password fields to support Firefox native password features.

Refactored and improved how separators are identified and handled.

Author: nero120

src/modules/app/app-login/app-login.component.html

@@ -66,7 +66,8 @@
           vm.platformSvc.getI18nString(vm.Strings.View.Login.Password.Label) }}</label>
               <input type="{{ vm.showPassword ? 'text' : 'password' }}" name="txtPassword" ng-model="vm.password"
                      class="form-control" password-strength="vm.passwordComplexity" ng-disabled="vm.syncEnabled"
-                     maxlength="150" autocapitalize="off" autocorrect="off" spellcheck="false"
+                     maxlength="150" autocapitalize="off" autocomplete="new-password" autocorrect="off"
+                     spellcheck="false"
                      placeholder="{{ vm.platformSvc.getI18nString(vm.Strings.View.Login.Password.New) }}" />
               <button class="btn btn-icon btn-show-password" ng-class="{ 'active': vm.showPassword }"
                       ng-show="vm.password"

src/modules/app/app-search/bookmark-tree/bookmark-tree.component.html

@@ -3,7 +3,7 @@
           enable-edit-button="!vm.utilitySvc.isMobilePlatform(vm.platformSvc.platformName)"
           enable-select="vm.utilitySvc.isMobilePlatform(vm.platformSvc.platformName)"
           is-selected="vm.selectedBookmark === bookmark.id" share-bookmark="vm.shareBookmark()"
-          ng-class="{ 'folder': vm.bookmarkHelperSvc.isFolder(bookmark), 'open': bookmark.displayChildren, 'animate': vm.selectedBookmark === bookmark.id }"
+          ng-class="{ 'folder': vm.isFolder(bookmark), 'open': bookmark.displayChildren, 'animate': vm.selectedBookmark === bookmark.id }"
           hm-press="vm.utilitySvc.isMobilePlatform(vm.platformSvc.platformName) && bookmark.url && vm.utilitySvc.handleEvent(vm.selectBookmark(), $event, bookmark.id)">
   <bookmark-tree ng-model="bookmark.children" selected-bookmark="vm.selectedBookmark" edit-bookmark="vm.editBookmark()"
                  select-bookmark="vm.selectBookmark()" share-bookmark="vm.shareBookmark()"

src/modules/app/app-search/bookmark-tree/bookmark-tree.component.ts

@@ -1,10 +1,12 @@
 import { Component, Input, Output } from 'angular-ts-decorators';
 import autobind from 'autobind-decorator';
 import BookmarkHelperService from '../../../shared/bookmark/bookmark-helper/bookmark-helper.service';
+import { BookmarkType } from '../../../shared/bookmark/bookmark.enum';
 import { Bookmark } from '../../../shared/bookmark/bookmark.interface';
 import { PlatformService } from '../../../shared/global-shared.interface';
 import UtilityService from '../../../shared/utility/utility.service';
 import AppHelperService from '../../shared/app-helper/app-helper.service';
+import { BookmarkTreeItem } from '../app-search.interface';
 
 @autobind
 @Component({
@@ -41,4 +43,9 @@ export default class BookmarkTreeComponent {
     this.platformSvc = PlatformSvc;
     this.utilitySvc = UtilitySvc;
   }
+
+  isFolder(bookmark: BookmarkTreeItem): boolean {
+    const bookmarkType = this.bookmarkHelperSvc.getBookmarkType(bookmark);
+    return bookmarkType === BookmarkType.Container || bookmarkType === BookmarkType.Folder;
+  }
 }

src/modules/app/app-search/bookmark/bookmark.component.html

@@ -1,4 +1,4 @@
-<div class="separator" ng-if="vm.bookmarkHelperSvc.isSeparator(vm.bookmark)"></div>
+<div class="separator" ng-if="vm.isSeparator(vm.bookmark)"></div>
 <div class="menu" ng-class="{ 'animate animate-fade-in': vm.enableSelect }" ng-if="vm.enableSelect"
      ng-show="vm.isSelected" tabindex="-1">
   <button class="btn btn-fab" title="{{ vm.platformSvc.getI18nString(vm.Strings.Button.ShareBookmark) }}"
@@ -18,7 +18,7 @@
     <span class="sr-only">{{ vm.platformSvc.getI18nString(vm.Strings.Button.DeleteBookmark) }}</span>
   </button>
 </div>
-<div class="bookmark-content" ng-if="vm.bookmark.url && !vm.bookmarkHelperSvc.isSeparator(vm.bookmark)"
+<div class="bookmark-content" ng-if="vm.bookmark.url && !vm.isSeparator(vm.bookmark)"
      ng-click="!vm.enableSelect && vm.utilitySvc.handleEvent(vm.appHelperSvc.openUrl, $event,  vm.bookmark.url)"
      hm-tap="vm.utilitySvc.handleEvent(vm.appHelperSvc.openUrl, $event,  vm.bookmark.url)">
   <h4 class="bookmark-heading" ng-if="vm.bookmark.title">{{ vm.bookmark.title }}</h4>
@@ -30,7 +30,7 @@ <h4 class="bookmark-heading" ng-if="!vm.bookmark.title">
     <div class="url">{{  vm.bookmark.url }}</div>
   </div>
 </div>
-<div class="bookmark-content" ng-if="!vm.bookmark.url && !vm.bookmarkHelperSvc.isSeparator(vm.bookmark)">
+<div class="bookmark-content" ng-if="!vm.bookmark.url && !vm.isSeparator(vm.bookmark)">
   <h4 class="bookmark-heading" ng-class="{ 'opening': vm.bookmark.open && !vm.bookmark.displayChildren }"
       ng-click="vm.utilitySvc.handleEvent(vm.clickBookmarkHeading, $event, vm.bookmark)" ng-if="vm.bookmark.title">
     {{ vm.bookmarkHelperSvc.getBookmarkTitleForDisplay(vm.bookmark) }}
@@ -48,7 +48,7 @@ <h4 class="bookmark-heading" ng-if="!vm.bookmark.title">
 </div>
 <button class="btn btn-icon btn-edit-bookmark"
         title="{{ vm.platformSvc.getI18nString(vm.Strings.Button.EditBookmark) }}"
-        ng-if="vm.enableEditButton && vm.bookmark.url && !vm.bookmarkHelperSvc.isSeparator(vm.bookmark)"
+        ng-if="vm.enableEditButton && vm.bookmark.url && !vm.isSeparator(vm.bookmark)"
         ng-click="vm.utilitySvc.handleEvent(vm.editBookmark(), $event,  vm.bookmark)">
   <i class="fas fa-edit" aria-hidden="true"></i>
   <span class="sr-only">{{ vm.platformSvc.getI18nString(vm.Strings.Button.EditBookmark) }}</span>

src/modules/app/app-search/bookmark/bookmark.component.ts

@@ -1,6 +1,7 @@
 import { Component, Input, Output } from 'angular-ts-decorators';
 import autobind from 'autobind-decorator';
 import BookmarkHelperService from '../../../shared/bookmark/bookmark-helper/bookmark-helper.service';
+import { BookmarkType } from '../../../shared/bookmark/bookmark.enum';
 import { Bookmark } from '../../../shared/bookmark/bookmark.interface';
 import { PlatformService } from '../../../shared/global-shared.interface';
 import UtilityService from '../../../shared/utility/utility.service';
@@ -72,4 +73,8 @@ export default class BookmarkComponent {
       }
     }, 100);
   }
+
+  isSeparator(bookmark: BookmarkTreeItem): boolean {
+    return this.bookmarkHelperSvc.getBookmarkType(bookmark) === BookmarkType.Separator;
+  }
 }