fix(ui): add padding before first icon node in timeline

[y3owk1n]

Summary by CodeRabbit

• Style
  • Improved visual alignment and spacing of tree lines and branch icons in the timeline view for better readability.
  • Adjusted annotation text and highlighting to enhance clarity and consistency in the timeline display.

[coderabbitai]

Walkthrough

The changes update the visual formatting and alignment of tree structures and timeline annotations in the codebase. In tree.lua, the rendering of tree lines is adjusted to improve the continuity and spacing of branch icons, especially for the root node and first column. In ui.lua, the timeline annotation string receives a leading space, and substring extraction indices are modified to account for multibyte or wide characters, affecting how highlights are applied to the timeline display. No changes are made to public function signatures or exported entities.

Changes

File(s)	Change Summary
lua/time-machine/tree.lua	Refined the formatting of tree lines in build_tree_lines to adjust spacing and alignment of icons, especially for the root node and first column.
lua/time-machine/ui.lua	Added a leading space to the timeline annotation string and updated substring extraction indices in set_highlights to support multibyte or wide characters.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TreeRenderer
    participant UIRenderer

    User->>TreeRenderer: Request tree lines
    TreeRenderer->>TreeRenderer: Format tree lines with improved spacing and icons
    TreeRenderer-->>User: Return visually aligned tree lines

    User->>UIRenderer: Display timeline annotation
    UIRenderer->>UIRenderer: Add leading space, adjust substring extraction for highlights
    UIRenderer-->>User: Show updated timeline display

Loading

Possibly related PRs

• fix(tree): nicer connector for root node #78: Both PRs modify the build_tree_lines function in lua/time-machine/tree.lua to improve the visual formatting of tree connectors, specifically enhancing the root node's line drawing and spacing of tree branch icons.

Poem

A rabbit hopped through lines of code,
Adjusting trees where icons showed.
With spaces neat and highlights bright,
The timeline now aligns just right.
Multibyte paths and branches clear—
The forest’s never looked so dear!
🐇🌳✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21fef8d and 9f3dac2.

📒 Files selected for processing (2)

• lua/time-machine/tree.lua (2 hunks)
• lua/time-machine/ui.lua (3 hunks)

🔇 Additional comments (6)

lua/time-machine/tree.lua (3)

129-134: Improved tree line formatting for root node

The change improves the visual appearance by replacing the vertical join + space with a vertical join + horizontal line for better visual continuity.

---

144-144: Added consistent spacing for first column vertical separator

The formatting change adds a leading space before the vertical icon, resulting in more balanced spacing around the separator.

---

152-163: Consistent alignment for entry symbols

This change conditionally adds a space before icons in the first column, ensuring consistent alignment regardless of column position. This properly addresses the PR objective to add padding before the first icon node.

lua/time-machine/ui.lua (3)

11-11: Added leading space to timeline annotation

This change aligns with the spacing improvements in tree.lua, providing consistent padding for the timeline annotation.

---

116-116: Adjusted substring extraction for multibyte character support

Multiplying the substring index by 2 helps properly handle wide/multibyte characters in the timeline display, improving the highlight positioning.

---

128-128: Consistent multibyte character handling

Similar to the previous change, this adjustment ensures proper handling of multibyte or wide characters when determining highlight regions.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.