fix(ui): ensure pattern matching for time section matches new config

[mtraworld]

Summary by CodeRabbit

• New Features
  • Added support for displaying and matching multiple time formats, including relative, pretty, and Unix timestamp formats, based on user configuration.

[coderabbitai]

Walkthrough

The code in the time-machine UI module was updated to support multiple time formats for parsing time strings in lines. Instead of a single pattern, a table of patterns is now used, and the appropriate pattern is selected based on user configuration.

Changes

File(s)	Change Summary
lua/time-machine/ui.lua	Replaced single time string matching pattern with a table of patterns for multiple time formats. Dynamic selection of pattern based on user configuration.

Poem

In the warren of time, new formats appear,
A hop, a skip, from "ago" to the year.
Now pretty and unix, all join the parade,
As rabbits with patterns, our code is remade.
🕰️🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc61d84 and 81aad83.

📒 Files selected for processing (1)

• lua/time-machine/ui.lua (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• lua/time-machine/ui.lua

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

lua/time-machine/ui.lua (2)

164-164: Consider improving unix timestamp pattern flexibility.

The unix timestamp pattern (%d%d%d%d%d%d%d%d%d%d) assumes exactly 10 digits, but unix timestamps can be 9 digits (before 2001) or 13+ digits (millisecond precision). This could cause matching failures for edge cases.

Consider using a more flexible pattern:

-				unix = "(%d%d%d%d%d%d%d%d%d%d)%s*(.*)$", -- e.g., "1720048500 #tag"
+				unix = "(%d%d%d%d%d%d%d%d%d+)%s*(.*)$", -- e.g., "1720048500 #tag"

---

167-167: Consider caching config to improve performance.

Loading the config module inside the highlighting function (which may be called frequently) could impact performance. Consider caching the config or moving this logic to module initialization.

Move config loading to module level:

+local config = require("time-machine.config").config

 --- Set highlights for the UI
 local function set_highlights(bufnr, seq_map, curr_seq, lines)
 	-- ... existing code ...
-			local config = require("time-machine.config").config

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66b173e and cc61d84.

📒 Files selected for processing (1)

• lua/time-machine/ui.lua (1 hunks)