Replace StyleCI with PHP CS Fixer (#220)

Author: mspirkov

.github/workflows/rector-cs.yml

@@ -0,0 +1,27 @@
+name: Rector + PHP CS Fixer
+
+on:
+  pull_request_target:
+    paths:
+      - 'src/**'
+      - 'tests/**'
+      - '.github/workflows/rector-cs.yml'
+      - 'composer.json'
+      - 'rector.php'
+      - '.php-cs-fixer.dist.php'
+
+permissions:
+  contents: read
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  rector:
+    uses: yiisoft/actions/.github/workflows/rector-cs.yml@master
+    secrets:
+      token: ${{ secrets.YIISOFT_GITHUB_TOKEN }}
+    with:
+      repository: ${{ github.event.pull_request.head.repo.full_name }}
+      php: '8.0'

.github/workflows/rector.yml

@@ -30,4 +30,6 @@ phpunit.phar
 # phpunit cache
 .phpunit.result.cache
 
-
+# PHP CS Fixer
+/.php-cs-fixer.cache
+/.php-cs-fixer.php

.gitignore

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+use PhpCsFixer\Config;
+use PhpCsFixer\Finder;
+use PhpCsFixer\Runner\Parallel\ParallelConfigFactory;
+
+$finder = (new Finder())->in([
+    __DIR__ . '/src',
+    __DIR__ . '/tests',
+]);
+
+// TODO: Update the configuration after raising the minimum PHP version
+return (new Config())
+    ->setRiskyAllowed(true)
+    ->setParallelConfig(ParallelConfigFactory::detect())
+    ->setRules([
+        '@PER-CS2.0' => true,
+        'nullable_type_declaration' => true,
+        'operator_linebreak' => true,
+        'ordered_types' => ['null_adjustment' => 'always_last', 'sort_algorithm' => 'none'],
+        'single_class_element_per_statement' => true,
+        'types_spaces' => true,
+        'no_unused_imports' => true,
+        'ordered_class_elements' => true,
+        'class_attributes_separation' => ['elements' => ['method' => 'one']],
+        'declare_strict_types' => true,
+        'native_function_invocation' => true,
+        'native_constant_invocation' => true,
+        'fully_qualified_strict_types' => [
+            'import_symbols' => true
+        ],
+        'global_namespace_import' => [
+            'import_classes' => true,
+            'import_constants' => true,
+            'import_functions' => true,
+        ],
+    ])
+    ->setFinder($finder);

.php-cs-fixer.dist.php

@@ -2,7 +2,7 @@
 
 ## 1.3.2 under development
 
-- no changes in this release.
+- Enh #220: Explicitly import functions in "use" section (@mspirkov)
 
 ## 1.3.1 December 02, 2025
 

.styleci.yml

@@ -32,6 +32,7 @@
     },
     "require-dev": {
         "bamarni/composer-bin-plugin": "^1.8.3",
+        "friendsofphp/php-cs-fixer": "^3.66",
         "maglnet/composer-require-checker": "^4.4",
         "phpunit/phpunit": "^9.6.22",
         "rector/rector": "^2.0.10",

CHANGELOG.md

@@ -34,7 +34,7 @@ final class Factory
     public function __construct(
         ?ContainerInterface $container = null,
         array $definitions = [],
-        private bool $validate = true
+        private bool $validate = true,
     ) {
         $this->validateDefinitions($definitions);
         $this->internalContainer = new FactoryInternalContainer($container, $definitions);
@@ -54,21 +54,6 @@ public function withDefinitions(array $definitions): self
         return $new;
     }
 
-    /**
-     * @param array $definitions Definitions to validate.
-     * @psalm-param array<string, mixed> $definitions
-     *
-     * @throws InvalidConfigException
-     */
-    private function validateDefinitions(array $definitions): void
-    {
-        if ($this->validate) {
-            foreach ($definitions as $id => $definition) {
-                DefinitionValidator::validate($definition, $id);
-            }
-        }
-    }
-
     /**
      * Creates a new object using the given configuration.
      *
@@ -140,6 +125,21 @@ public function create(mixed $config): mixed
         return $this->internalContainer->create($definition);
     }
 
+    /**
+     * @param array $definitions Definitions to validate.
+     * @psalm-param array<string, mixed> $definitions
+     *
+     * @throws InvalidConfigException
+     */
+    private function validateDefinitions(array $definitions): void
+    {
+        if ($this->validate) {
+            foreach ($definitions as $id => $definition) {
+                DefinitionValidator::validate($definition, $id);
+            }
+        }
+    }
+
     /**
      * @throws InvalidConfigException
      */
@@ -155,7 +155,7 @@ private function createDefinition(mixed $config): DefinitionInterface
         ) {
             $definition = $this->mergeDefinitions(
                 $containerDefinition,
-                $definition
+                $definition,
             );
         }
 

composer.json

@@ -18,6 +18,7 @@
 use function array_key_exists;
 use function is_object;
 use function is_string;
+use function sprintf;
 
 /**
  * Factory's primary container.
@@ -42,9 +43,8 @@ final class FactoryInternalContainer implements ContainerInterface
      */
     public function __construct(
         private ?ContainerInterface $container,
-        private array $definitions
-    ) {
-    }
+        private array $definitions,
+    ) {}
 
     /**
      * @param array<string, mixed> $definitions Definitions to create objects with.
@@ -117,14 +117,14 @@ public function getDefinition(string $id): DefinitionInterface
                 ) {
                     $this->definitionInstances[$id] = $this->getDefinition($this->definitions[$id]);
                 } else {
-                    $this->definitionInstances[$id] =
-                        (is_string($this->definitions[$id]) && class_exists($this->definitions[$id]))
+                    $this->definitionInstances[$id]
+                        = (is_string($this->definitions[$id]) && class_exists($this->definitions[$id]))
                             ? ArrayDefinition::fromPreparedData($this->definitions[$id])
                             : Normalizer::normalize($this->definitions[$id], $id);
                 }
             } else {
                 throw new LogicException(
-                    sprintf('No definition found for "%s".', $id)
+                    sprintf('No definition found for "%s".', $id),
                 );
             }
         }
@@ -157,8 +157,8 @@ private function build(string $id): mixed
                 sprintf(
                     'Circular reference to "%s" detected while creating: %s.',
                     $id,
-                    implode(', ', array_keys($this->creatingIds))
-                )
+                    implode(', ', array_keys($this->creatingIds)),
+                ),
             );
         }
 

src/Factory.php

@@ -7,6 +7,8 @@
 use Exception;
 use Psr\Container\NotFoundExceptionInterface;
 
+use function sprintf;
+
 /**
  * NotFoundException is thrown when no definition or class was found in the factory for a given ID.
  */
@@ -16,7 +18,7 @@ final class NotFoundException extends Exception implements NotFoundExceptionInte
      * @param string $id ID of the definition or name of the class that was not found.
      */
     public function __construct(
-        private string $id
+        private string $id,
     ) {
         parent::__construct(sprintf('No definition or class found or resolvable for %s.', $id));
     }