ENH: support per-vertex opacity in 3D overlays#13706
Open
PragnyaKhandelwal wants to merge 7 commits intomne-tools:mainfrom
Open
ENH: support per-vertex opacity in 3D overlays#13706PragnyaKhandelwal wants to merge 7 commits intomne-tools:mainfrom
PragnyaKhandelwal wants to merge 7 commits intomne-tools:mainfrom
Conversation
PragnyaKhandelwal
requested review from
drammock,
larsoner and
wmvanvliet
as code owners
wmvanvliet
reviewed
Feb 28, 2026
Contributor
wmvanvliet
left a comment
wmvanvliet
left a comment
There was a problem hiding this comment.
Could we modify one of the examples, or add a new one, to show off this functionality?
Code looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #13679
What does this implement/fix?
This PR adds support for per-vertex opacity in 3D distributed source overlays.
Previously, overlay opacity was effectively handled as a scalar value. This change allows opacity to be either:
a scalar (existing behavior), or
a 1D array with one value per vertex ([shape (n_vertices,)]
Implementation details:
Keeps the existing per-vertex RGBA pipeline and lets VTK handle triangle interpolation.
Adds explicit validation and clear error messages for invalid opacity shapes.
Updates related documentation for overlay alpha behavior.
Adds tests for:
valid per-vertex opacity usage, and
invalid-shape opacity failure cases.
Additional information
The branch is clean and focused on this issue.
No extra/demo files are included in the PR.
Targeted tests and pre-commit checks for modified files pass locally.