🐛 fix(patch): detect python -m pre_commit#115
Merged
gaborbernat merged 1 commit intotox-dev:mainfrom Feb 18, 2026
Merged
Conversation
During .pth processing, sys.argv is ["-m", ...] without the module name. The patch detection missed this case, so `python -m pre_commit` ran without uv. Use sys.orig_argv (available since Python 3.10) to check for the pre_commit module name. Fixes tox-dev#80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
python -m pre_commitbypassed the uv patching entirely because the.pthfile's detection logic didn't account for how Python populatessys.argvduring module execution. When invoked with-m, Python setssys.argv[0]to"-m"during site initialization (when the.pthfile runs), stripping the module name from the arguments. This meant tox configs using{env_python} -m pre_commitwould silently fall back to vanilla pre-commit without uv.The fix uses
sys.orig_argv(available since Python 3.10, which is the project's minimum) to inspect the original command line and detect whenpre_commitis the-mtarget module. The detection logic was also extracted into a standalone function to keep the boolean expression count within linting limits.Fixes #80