fix: set outputs/env vars for empty string field values#132
fix: set outputs/env vars for empty string field values#132volodymyrZotov merged 1 commit into1Password:mainfrom
Conversation
Empty string field values from 1Password were causing the action to skip setting outputs and environment variables entirely. This was inconsistent with `op run` behavior, which sets the variable with an empty value. - Change falsy check to explicit null/undefined check in extractSecret - Skip setSecret for empty strings to avoid runner warning - Add tests for empty string value handling
|
Hi @volodymyrZotov, I hope you don't mind me reaching out directly. I noticed you've been reviewing PRs in this repo recently. |
|
/ok-to-test sha=13f927c |
|
✅ E2E tests passed. |
volodymyrZotov
left a comment
volodymyrZotov
left a comment
There was a problem hiding this comment.
Looks good @toga4 ! Thank you for your input! 🌟
|
@volodymyrZotov Thanks for merging! 🎉 |
|
Hi @volodymyrZotov, friendly follow-up on this. I've been trying to use the fix from this PR by pinning to the merge commit, but I noticed that Would it be possible to rebuild Thanks! |
|
@toga4 correct. The change is not released yet. The team will make a new release shortly. |
|
@volodymyrZotov Thanks for confirming! Looking forward to the release. |
2 participants
op runbehavior: empty field values result in defined variables with empty string valuessetSecretfor empty strings to avoid runner warningFixes #131