Add secret ref validation#135
Merged
JillRegan merged 13 commits intofeature/migrate-to-sdkfrom Feb 23, 2026
Merged
Conversation
Base automatically changed from
jill/use-sdk-for-service-account
to
feature/migrate-to-sdk
February 20, 2026 13:22
bertrmz
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds validation for secret references before attempting to load them from 1Password. This ensures that malformed or invalid secret references fail fast with clear error messages instead of causing issues downstream.
op env lswhich validates already so we can avoid adding logic here until Connect is migrated.Changes
E2E test was added to test this expected failure