Ensure that the action is backwards-compatible#25
Merged
Conversation
Closed
florisvdg
reviewed
Dec 22, 2022
florisvdg
reviewed
Dec 22, 2022
Contributor
There was a problem hiding this comment.
Isn't the real solution here to make the CLI-based action v2? And keep the curl-based v1?
Given that there have already been v1.1.x tags containing these changes, the path forward would be to create a v1.x.x release to undo the breaking changes. The changes can be added again in a v2 release.
florisvdg
approved these changes
Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings 2 changes that ensure that the GitHub Action is backwards compatible:
http://if the prefix is not provided in theOP_CONNECT_HOST(this is caused by the fact thatcurlguesses the protocol if not provided, which we missed when switching to using the 1Password CLI as the backend of the action)export-envtotrue, since that was the default behavior of the action until we added the possibility to export secrets as step's output.Also, the documentation is adjusted to reflect these changes.