Conversation
0c75465 to
c100474
Compare
84bc515 to
06e8c24
Compare
06e8c24 to
7f0c7f7
Compare
krboktv
reviewed
Aug 28, 2025
krboktv
reviewed
Aug 28, 2025
restrict transfer for ETHOrders erc20 tokens
f705fb6 to
a87d8c0
Compare
krboktv
reviewed
Sep 1, 2025
krboktv
reviewed
Sep 1, 2025
krboktv
reviewed
Sep 1, 2025
Sunnesoft
approved these changes
Sep 24, 2025
Contributor
Sunnesoft
left a comment
There was a problem hiding this comment.
Pls check if we really use libs - if not, remove it. But it not so critical
Sunnesoft
approved these changes
Sep 26, 2025
[PT1-167] Deploy NativeOrderFactory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented logic, haven't updated tests yet.
Key highlights:
depositForOrderwhile we can usedepositForOrderHash? It's safe – we store hashes per makers.msg.senders forpostInteractionwith maker extra dataLOP.hash()call withEIP712Aliento compute hash with LOP'sname/version/address(this)