Skip to content

Reimplement ETHOrders logic#384

Merged
SevenSwen merged 73 commits intomasterfrom
feature/new-eth-orders
Oct 1, 2025
Merged

Reimplement ETHOrders logic#384
SevenSwen merged 73 commits intomasterfrom
feature/new-eth-orders

Conversation

@k06a
Copy link
Contributor

@k06a k06a commented Aug 18, 2025

Implemented logic, haven't updated tests yet.

Key highlights:

  • Do we ever need depositForOrder while we can use depositForOrderHash? It's safe – we store hashes per makers.
  • Fusion and Fusion+ support: we can pass allowed msg.senders for postInteraction with maker extra data
  • Replaced LOP.hash() call with EIP712Alien to compute hash with LOP's name/version/address(this)

@k06a k06a requested a review from Copilot August 18, 2025 14:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@k06a k06a force-pushed the feature/new-eth-orders branch from 0c75465 to c100474 Compare August 18, 2025 19:14
@k06a k06a force-pushed the feature/new-eth-orders branch 2 times, most recently from 84bc515 to 06e8c24 Compare August 21, 2025 19:28
@k06a k06a force-pushed the feature/new-eth-orders branch from 06e8c24 to 7f0c7f7 Compare August 21, 2025 19:33
@k06a k06a force-pushed the feature/new-eth-orders branch from f705fb6 to a87d8c0 Compare September 1, 2025 08:57
Copy link
Contributor

@Sunnesoft Sunnesoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check if we really use libs - if not, remove it. But it not so critical

@SevenSwen SevenSwen merged commit 1e88b2e into master Oct 1, 2025
6 checks passed
@SevenSwen SevenSwen deleted the feature/new-eth-orders branch October 1, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants