fix: replace remaining hardcoded lists with dynamic discovery#311
Merged
jpelaez-23blocks merged 1 commit intomainfrom Mar 24, 2026
Merged
fix: replace remaining hardcoded lists with dynamic discovery#311jpelaez-23blocks merged 1 commit intomainfrom
jpelaez-23blocks merged 1 commit intomainfrom
Conversation
Code review found three more hardcoded lists that missed the dynamic discovery treatment: - verify-installation.sh: skill list missing agent-identity - verify-installation.sh: AMP script list (12 of 14) - install-plugin.sh: AMP script verification (10 of 14) All three now auto-discover from the plugin directory, consistent with how skill installation and verification already work. Also fixed banner alignment (cosmetic). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review of PR #310 found three more hardcoded lists that missed the dynamic discovery treatment:
verify-installation.shskills — hardcoded list of 6 skills, missingagent-identityverify-installation.shAMP scripts — hardcoded 12 of 14 scriptsinstall-plugin.shAMP verification — hardcoded 10 of 14 scriptsAll three now auto-discover from the plugin directory using the same glob pattern as installation.
Also fixed banner alignment (cosmetic — 3 lines were 1 char short).
Test plan
bash -nsyntax check on both filesyarn test— 545 pass🤖 Generated with Claude Code