Skip to content

[4.3] PISTON-1142: continue config menu after deleting VM temp greeting#6643

Open
danielfinke wants to merge 1 commit into2600hz:4.3from
voxter:pr-PISTON-1142-continue-config-menu-after-deleting-temp-greeting
Open

[4.3] PISTON-1142: continue config menu after deleting VM temp greeting#6643
danielfinke wants to merge 1 commit into2600hz:4.3from
voxter:pr-PISTON-1142-continue-config-menu-after-deleting-temp-greeting

Conversation

@danielfinke
Copy link
Contributor

  • Resolves crash after deleting temporary greeting

…ng (2600hz#6643)

- Resolves crash after deleting temporary greeting
@danielfinke danielfinke force-pushed the pr-PISTON-1142-continue-config-menu-after-deleting-temp-greeting branch from 44b9cd3 to a21d42e Compare October 16, 2020 00:13
@harenson
Copy link
Contributor

Hi @danielfinke may you please provide the steps to reproduce the crash? Thanks.

@danielfinke
Copy link
Contributor Author

Hey @harenson, the crash will be possible, currently, if the config menu is entered due to "announcement_only": true on the voicemail box. check_mailbox_menu/2 skips the main menu and goes right to the config menu, as it should. The crash will occur in the <<"check">> clause of handle/2 when the temporary greeting is deleted. Rather than add an extra clause to handle a mailbox return at the top level handle/2 call, which would have to go thru check_mailbox/2 etc. all over again, I just changed the post-delete action to go back to the config menu, like other config options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants