Skip to content

feat(logging): Add prometheus metrics & structure logs#45

Merged
42atomys merged 19 commits intomainfrom
42Atomys/issue42
Mar 13, 2022
Merged

feat(logging): Add prometheus metrics & structure logs#45
42atomys merged 19 commits intomainfrom
42Atomys/issue42

Conversation

@42atomys
Copy link
Owner

@42atomys 42atomys commented Mar 12, 2022

Relative Issues: Resolve #42

Describe the pull request

Add a prometheus endpoint to provide metrics about application and structure the logs given by the application

TODO

  • Add prometheus /metrics endpoint
  • Add possibility to enable/disable the prometheus endpoint via configuration
  • Add a logging middleware to provide more logs when application is running

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
no

Additional context
Documentation here : https://github.com/42Atomys/webhooked/wiki/Observability

@42atomys 42atomys added aspect/dex 🤖 Concerns developers' experience with the codebase priority/p4-later 🧊 🧊 Low – not urgent, can wait (P4) clarity/obvious 🟩 Clear, simple and can be executed without thinking labels Mar 12, 2022
@42atomys 42atomys self-assigned this Mar 12, 2022
@42atomys 42atomys added this to the 1.0 milestone Mar 12, 2022
@42atomys 42atomys marked this pull request as ready for review March 13, 2022 00:50
@42atomys 42atomys requested a review from rgaiffe as a code owner March 13, 2022 00:50
@42atomys
Copy link
Owner Author

@rgaiffe takes a look 👀

@42atomys 42atomys merged commit e01f2c8 into main Mar 13, 2022
@42atomys 42atomys deleted the 42Atomys/issue42 branch March 13, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aspect/dex 🤖 Concerns developers' experience with the codebase clarity/obvious 🟩 Clear, simple and can be executed without thinking priority/p4-later 🧊 🧊 Low – not urgent, can wait (P4)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

feat: Prometheus /metrics data exportation

1 participant