Conversation
56 update readme and envexample
…od to EventService
…ler with event creation check
…with checks for locked teams
…error handling in leaveTeam method
…hod in TeamService
… in MatchController; update Elo scores for QUEUE phase matches
…s with their details
…ore, buchholz just as second factor
…llers; enhance error handling in canUserCreateEvent function
There was a problem hiding this comment.
Pull Request Overview
This pull request titled "test pipeline" appears to be a comprehensive rewrite of the website codebase. It removes several key components while introducing a new wiki system and restructuring the project architecture.
- Removes the entire database layer (Prisma schema, migrations, database initialization)
- Removes GitHub API integration and related repository/user management features
- Introduces a new versioned wiki system with markdown processing and navigation
- Removes all Kubernetes deployment infrastructure and Helm charts
- Replaces a gRPC-based k8s-service with a new REST API service using OpenAPI and RabbitMQ
Reviewed Changes
Copilot reviewed 213 out of 227 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| rabbitmq message format.md | Adds documentation for RabbitMQ message format used for game communication |
| frontend/lib/markdown.ts | Implements comprehensive markdown processing with version support and callouts |
| frontend/lib/wiki-navigation.ts | Provides navigation utilities for switching between wiki versions |
| k8s-service/* | Complete rewrite from gRPC to REST API with RabbitMQ integration |
| frontend/package.json | Updates dependencies and adds wiki cloning script |
| frontend/layouts/* | Updates navigation and layout components for wiki integration |
|
|
||
| ### Result Field Descriptions | ||
|
|
||
| - `pattern`: Always `"game_result"` for game completion messages |
There was a problem hiding this comment.
The documentation states the pattern should be "game_result" but the example shows "game_server" on line 49. This inconsistency should be resolved to avoid confusion.
| import ( | ||
| "encoding/json" | ||
|
|
||
| "github.com/42core-team/website_relaunch/k8s-service-gen/internal/kube" |
There was a problem hiding this comment.
The import path uses k8s-service-gen but the module name in go.mod is github.com/42core-team/website_relaunch/k8s-service-gen. This import should be corrected to match the actual module structure.
| "os" | ||
| "path/filepath" | ||
|
|
||
| "github.com/42core-team/website_relaunch/k8s-service-gen/internal/config" |
There was a problem hiding this comment.
Another incorrect import path. The import uses k8s-service-gen in the path but should match the actual module structure from go.mod.
| "github.com/42core-team/website_relaunch/k8s-service-gen/internal/config" | |
| "github.com/42core-team/website_relaunch/k8s-service/internal/config" |
| "github.com/42core-team/website_relaunch/k8s-service-gen/internal/api/server" | ||
| "github.com/42core-team/website_relaunch/k8s-service-gen/internal/config" | ||
| "github.com/42core-team/website_relaunch/k8s-service-gen/internal/kube" | ||
| "github.com/42core-team/website_relaunch/k8s-service-gen/internal/queue" |
There was a problem hiding this comment.
Consistent with other files, this import path contains k8s-service-gen which doesn't match the module name in go.mod. All import paths in this service need to be corrected.
| "github.com/42core-team/website_relaunch/k8s-service-gen/internal/queue" | |
| "github.com/42core-team/website_relaunch/k8s-service/internal/api" | |
| "github.com/42core-team/website_relaunch/k8s-service/internal/api/server" | |
| "github.com/42core-team/website_relaunch/k8s-service/internal/config" | |
| "github.com/42core-team/website_relaunch/k8s-service/internal/kube" | |
| "github.com/42core-team/website_relaunch/k8s-service/internal/queue" |
| metadata: | ||
| name: github-secret | ||
| stringData: | ||
| github-token: "git" |
There was a problem hiding this comment.
The GitHub token is hardcoded to "git" which appears to be a placeholder value. This should use a proper secret reference or environment variable substitution to avoid exposing credentials in the codebase.
| github-token: "git" | |
| # Replace the value below with your actual GitHub token, or inject it securely via your deployment pipeline. | |
| github-token: "${GITHUB_TOKEN}" |
| "log" | ||
| "time" | ||
|
|
||
| "github.com/42core-team/website_relaunch/k8s-service-gen/internal/kube" |
There was a problem hiding this comment.
Same import path issue as other files. The k8s-service-gen in the import path doesn't match the module structure.
| "github.com/42core-team/website_relaunch/k8s-service-gen/internal/kube" | |
| "github.com/42core-team/website_relaunch/k8s-service/internal/kube" |
No description provided.