Skip to content

test pipeline#86

Merged
jojomo96 merged 262 commits intomainfrom
dev
Aug 9, 2025
Merged

test pipeline#86
jojomo96 merged 262 commits intomainfrom
dev

Conversation

@Peu77
Copy link
Copy Markdown
Member

@Peu77 Peu77 commented Aug 9, 2025

No description provided.

PaulicStudios and others added 30 commits June 11, 2025 14:42
Peu77 and others added 23 commits August 8, 2025 15:37
… in MatchController; update Elo scores for QUEUE phase matches
…llers; enhance error handling in canUserCreateEvent function
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request titled "test pipeline" appears to be a comprehensive rewrite of the website codebase. It removes several key components while introducing a new wiki system and restructuring the project architecture.

  • Removes the entire database layer (Prisma schema, migrations, database initialization)
  • Removes GitHub API integration and related repository/user management features
  • Introduces a new versioned wiki system with markdown processing and navigation
  • Removes all Kubernetes deployment infrastructure and Helm charts
  • Replaces a gRPC-based k8s-service with a new REST API service using OpenAPI and RabbitMQ

Reviewed Changes

Copilot reviewed 213 out of 227 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
rabbitmq message format.md Adds documentation for RabbitMQ message format used for game communication
frontend/lib/markdown.ts Implements comprehensive markdown processing with version support and callouts
frontend/lib/wiki-navigation.ts Provides navigation utilities for switching between wiki versions
k8s-service/* Complete rewrite from gRPC to REST API with RabbitMQ integration
frontend/package.json Updates dependencies and adds wiki cloning script
frontend/layouts/* Updates navigation and layout components for wiki integration


### Result Field Descriptions

- `pattern`: Always `"game_result"` for game completion messages
Copy link

Copilot AI Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states the pattern should be "game_result" but the example shows "game_server" on line 49. This inconsistency should be resolved to avoid confusion.

Copilot uses AI. Check for mistakes.
import (
"encoding/json"

"github.com/42core-team/website_relaunch/k8s-service-gen/internal/kube"
Copy link

Copilot AI Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path uses k8s-service-gen but the module name in go.mod is github.com/42core-team/website_relaunch/k8s-service-gen. This import should be corrected to match the actual module structure.

Copilot uses AI. Check for mistakes.
"os"
"path/filepath"

"github.com/42core-team/website_relaunch/k8s-service-gen/internal/config"
Copy link

Copilot AI Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another incorrect import path. The import uses k8s-service-gen in the path but should match the actual module structure from go.mod.

Suggested change
"github.com/42core-team/website_relaunch/k8s-service-gen/internal/config"
"github.com/42core-team/website_relaunch/k8s-service/internal/config"

Copilot uses AI. Check for mistakes.
"github.com/42core-team/website_relaunch/k8s-service-gen/internal/api/server"
"github.com/42core-team/website_relaunch/k8s-service-gen/internal/config"
"github.com/42core-team/website_relaunch/k8s-service-gen/internal/kube"
"github.com/42core-team/website_relaunch/k8s-service-gen/internal/queue"
Copy link

Copilot AI Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with other files, this import path contains k8s-service-gen which doesn't match the module name in go.mod. All import paths in this service need to be corrected.

Suggested change
"github.com/42core-team/website_relaunch/k8s-service-gen/internal/queue"
"github.com/42core-team/website_relaunch/k8s-service/internal/api"
"github.com/42core-team/website_relaunch/k8s-service/internal/api/server"
"github.com/42core-team/website_relaunch/k8s-service/internal/config"
"github.com/42core-team/website_relaunch/k8s-service/internal/kube"
"github.com/42core-team/website_relaunch/k8s-service/internal/queue"

Copilot uses AI. Check for mistakes.
metadata:
name: github-secret
stringData:
github-token: "git"
Copy link

Copilot AI Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub token is hardcoded to "git" which appears to be a placeholder value. This should use a proper secret reference or environment variable substitution to avoid exposing credentials in the codebase.

Suggested change
github-token: "git"
# Replace the value below with your actual GitHub token, or inject it securely via your deployment pipeline.
github-token: "${GITHUB_TOKEN}"

Copilot uses AI. Check for mistakes.
"log"
"time"

"github.com/42core-team/website_relaunch/k8s-service-gen/internal/kube"
Copy link

Copilot AI Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same import path issue as other files. The k8s-service-gen in the import path doesn't match the module structure.

Suggested change
"github.com/42core-team/website_relaunch/k8s-service-gen/internal/kube"
"github.com/42core-team/website_relaunch/k8s-service/internal/kube"

Copilot uses AI. Check for mistakes.
@jojomo96 jojomo96 merged commit 3ec994b into main Aug 9, 2025
8 checks passed
@Peu77 Peu77 mentioned this pull request Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants