Fix dependency injection issue in CustomTimespanShiftSelectorComponent#103
Open
vamshikiran065-jpg wants to merge 1 commit into52North:developfrom
Open
Fix dependency injection issue in CustomTimespanShiftSelectorComponent#103vamshikiran065-jpg wants to merge 1 commit into52North:developfrom
vamshikiran065-jpg wants to merge 1 commit into52North:developfrom
Conversation
This PR resolves a potential dependency injection issue in CustomTimespanShiftSelectorComponent. The component extends TimespanShiftSelectorComponent, which relies on Angular’s DI system. However, the Time service may not be properly injected if it is not explicitly provided or correctly passed through the constructor. Changes made: Ensured the Time service is correctly injected and passed to the parent constructor. Updated the constructor to use the override keyword for better compatibility with modern Angular versions. Clarified dependency handling to prevent runtime errors such as NullInjectorError. These changes improve reliability and ensure proper integration with Angular’s dependency injection system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a potential dependency injection issue in CustomTimespanShiftSelectorComponent.
The component extends TimespanShiftSelectorComponent, which relies on Angular’s DI system. However, the Time service may not be properly injected if it is not explicitly provided or correctly passed through the constructor.
Changes made:
Ensured the Time service is correctly injected and passed to the parent constructor. Updated the constructor to use the override keyword for better compatibility with modern Angular versions. Clarified dependency handling to prevent runtime errors such as NullInjectorError.
These changes improve reliability and ensure proper integration with Angular’s dependency injection system.