Added basque translation#113
Added basque translation#113icillero wants to merge 19 commits into68publishers:mainfrom icillero:main
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughA new Basque language translation file has been added to provide localized strings for cookie consent and configuration user interface elements. This file contains key-value pairs for modal titles, descriptions, button labels, cookie category explanations, and related UI text. Changes
Possibly related PRs
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (11)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/resources/translations/eu.json(1 hunks)
🔇 Additional comments (1)
src/resources/translations/eu.json (1)
1-59:Details
✅ Verification successful
Ensure translation key coverage.
Verify thateu.jsonmirrors all keys from the other locale files (e.g.,en.json). Run the following to spot missing or extra entries:
🏁 Script executed:
#!/bin/bash set -eo pipefail comm -3 \ <(jq -r 'keys_unsorted[]' src/resources/translations/en.json | sort) \ <(jq -r 'keys_unsorted[]' src/resources/translations/eu.json | sort)Length of output: 285
I’ll re-verify key coverage using a Python script since
commisn’t available:
🏁 Script executed:
#!/usr/bin/env bash python3 - << 'EOF' import json, sys en_path = 'src/resources/translations/en.json' eu_path = 'src/resources/translations/eu.json' with open(en_path, encoding='utf-8') as f: en_keys = set(json.load(f).keys()) with open(eu_path, encoding='utf-8') as f: eu_keys = set(json.load(f).keys()) missing = sorted(en_keys - eu_keys) extra = sorted(eu_keys - en_keys) if missing: print("Missing in eu.json:") for k in missing: print(" -", k) if extra: print("Extra in eu.json:") for k in extra: print(" -", k) # Exit with non-zero if any discrepancies found if missing or extra: sys.exit(1) EOFLength of output: 11
Translation key coverage verified – no missing or extra entries in eu.json
I ran a Python comparison of keys inen.jsonandeu.jsonand confirmed they match exactly. No action required.
|
Hi @icillero, thank you for your contribution! There are severeal issues. Could you solve them? |
Hi, I think I managed to resolve the issues, but I do not know how to do just 1 commit, sorry :-) Do I have to do a pull request again? |
|
@icillero Right time to practice rebase with fixups https://www.youtube.com/watch?v=P--NXvgsxK0 |
Creation of basque language file
- added new option "Visible & Readonly, Disabled always" for field "Visibility and default state" in the GTM template - added method `StoragePool.findVisibleReadonlyDisabled()` - decorated methods `run`, `updateLanguage` and `accept` to implement the new storage state
- added the field `Package destination` in the GTM template - updated configuration table in the README and added the section "About the package destination" - updated CHANGELOG
…rage is denied show the modal again after" in the GTM template when a variable is used in the field "Visibility and default state"
…ty_storage' in undefined" when no storage is enabled
…gs modal that was opened through an element created by the "Settings modal trigger selector" option
…es tables) are now automatically collapsed when the modal is closed.
|
@icillero You can always make changes to your current PR without creating a new one. It's always good to learn something new and improve yourself. Anyway, thanks for the translations 👍 |
3 participants
Added basque translation
Summary by CodeRabbit