Change to using ACCESS-NRI organisation OASIS3-mct code#181
Change to using ACCESS-NRI organisation OASIS3-mct code#181aidanheerdegen merged 5 commits intomainfrom
Conversation
|
CD was too smart and didn't fire with initial commit because there was no change to |
|
🚀 Attempted to deploy 🖥️
|
|
🚀 Attempted to deploy 🖥️
|
|
Testing in ACCESS-NRI/access-esm1.6-configs#403. Up to this point is bitwise reproducible. 🥳 |
@aidanheerdegen Thanks for reordering the packages - that looks good to me! Since you are in the process of doing the update anyway, it might be worthwhile to upgrade to the latest v6 from upstream (assuming the results are bitwise identical) |
👍
Wouldn't that entail performance testing v6 as well? If so we'd want to make sure it was worth it. The differences between v5 and v6 are detailed here: https://gitlab.com/cerfacs/oasis3-mct/-/blob/release/v6/doc/UGA4_changes.tex?ref_type=heads#L23-48 |
|
🚀 Attempted to deploy 🖥️
|
|
🚀 Attempted to deploy 🖥️
|
|
Checked the build logs and they seem to have the most recent versions of the UM flags modified by @manodeep |
|
🚀 Attempted to deploy 🖥️
|
|
🚀 Attempted to deploy 🖥️
|
|
🚀 Attempted to deploy 🖥️
|
|
🚀 Attempted to deploy 🖥️
|
|
Confirmed bitwise identical for dev-historical+concentrations with access-esm1p6/pr181-8. This is ready to merge subject to review. |
|
🚀 Attempted to deploy 🖥️
|
|
🚀 Attempted to deploy 🖥️
|
|
Updates pass repro still: ACCESS-NRI/access-esm1.6-configs#403 (comment) Shall we clean up the commit history ? |
5115e40 to
74412fc
Compare
|
🚀 Attempted to deploy 🖥️
|
anton-seaice
left a comment
There was a problem hiding this comment.
THanks @aidanheerdegen -
Use access-spack-packages version with UM optimisation changes reverted.
|
🚀 Attempted to deploy 🖥️
|
|
I have split out the UM optimisation changes. Hasn't deployed because Gadi is in maintenance mode. Will rerun deployment when it is back up. |
|
!redeploy |
|
🚀 Attempted to deploy 🖥️
|
This PR will close #179 by specifying a version of OASIS3-mct that uses code from the ACCESS-NRI organisation fork.
Will also close #117 (reorder packages) and hopefully close #180 (use all spack versions) at the same time.
🚀 The latest prerelease
access-esm1p6/pr181-13at 0693b5e is here: #181 (comment) 🚀