Fully revert config_src/external/GFDL_ocean_BGC directory#21
Merged
dougiesquire merged 2 commits into2025.08from Aug 5, 2025
Merged
Fully revert config_src/external/GFDL_ocean_BGC directory#21dougiesquire merged 2 commits into2025.08from
config_src/external/GFDL_ocean_BGC directory#21dougiesquire merged 2 commits into2025.08from
Conversation
…ean_BGC/generic_tracer.F90
dougiesquire
added a commit
that referenced
this pull request
Aug 13, 2025
In mom-ocean#1664, src/tracer/MOM_generic_tracer.F90 was moved to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90. This was done to simplify COBALT v3 development. However, having MOM_generic_tracer.F90 in the generic_tracers codebase doesnt work when compiling generic_tracers as a library, so we maintain MOM_generic_tracer.F90 in the MOM6 codebase. This reverts commits 2208dd7 and fcf5fff.
dougiesquire
added a commit
that referenced
this pull request
Aug 21, 2025
In mom-ocean#1664, src/tracer/MOM_generic_tracer.F90 was moved to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90. This was done to simplify COBALT v3 development. However, having MOM_generic_tracer.F90 in the generic_tracers codebase doesnt work when compiling generic_tracers as a library, so we maintain MOM_generic_tracer.F90 in the MOM6 codebase. This reverts commits 2208dd7 and fcf5fff.
dougiesquire
added a commit
that referenced
this pull request
Aug 22, 2025
In mom-ocean#1664, src/tracer/MOM_generic_tracer.F90 was moved to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90. This was done to simplify COBALT v3 development. However, having MOM_generic_tracer.F90 in the generic_tracers codebase doesnt work when compiling generic_tracers as a library, so we maintain MOM_generic_tracer.F90 in the MOM6 codebase. This reverts commits 2208dd7 and fcf5fff.
dougiesquire
added a commit
that referenced
this pull request
Nov 27, 2025
In mom-ocean#1664, src/tracer/MOM_generic_tracer.F90 was moved to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90. This was done to simplify COBALT v3 development. However, having MOM_generic_tracer.F90 in the generic_tracers codebase doesnt work when compiling generic_tracers as a library, so we maintain MOM_generic_tracer.F90 in the MOM6 codebase. This reverts commits 2208dd7 and fcf5fff.
dougiesquire
added a commit
that referenced
this pull request
Jan 12, 2026
In mom-ocean#1664, src/tracer/MOM_generic_tracer.F90 was moved to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90. This was done to simplify COBALT v3 development. However, having MOM_generic_tracer.F90 in the generic_tracers codebase doesnt work when compiling generic_tracers as a library, so we maintain MOM_generic_tracer.F90 in the MOM6 codebase. This reverts commits 2208dd7 and fcf5fff.
dougiesquire
added a commit
that referenced
this pull request
Feb 10, 2026
In mom-ocean#1664, src/tracer/MOM_generic_tracer.F90 was moved to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90. This was done to simplify COBALT v3 development. However, having MOM_generic_tracer.F90 in the generic_tracers codebase doesnt work when compiling generic_tracers as a library, so we maintain MOM_generic_tracer.F90 in the MOM6 codebase. This reverts commits 2208dd7 and fcf5fff.
dougiesquire
added a commit
that referenced
this pull request
Feb 10, 2026
In mom-ocean#1664, src/tracer/MOM_generic_tracer.F90 was moved to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90. This was done to simplify COBALT v3 development. However, having MOM_generic_tracer.F90 in the generic_tracers codebase doesnt work when compiling generic_tracers as a library, so we maintain MOM_generic_tracer.F90 in the MOM6 codebase. This reverts commits 2208dd7 and fcf5fff.
dougiesquire
added a commit
that referenced
this pull request
Feb 17, 2026
In mom-ocean#1664, src/tracer/MOM_generic_tracer.F90 was moved to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90. This was done to simplify COBALT v3 development. However, having MOM_generic_tracer.F90 in the generic_tracers codebase doesnt work when compiling generic_tracers as a library, so we maintain MOM_generic_tracer.F90 in the MOM6 codebase. This reverts commits 2208dd7 and fcf5fff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fully reverts the
config_src/external/GFDL_ocean_BGCdirectory following the decision upstream to movesrc/tracer/MOM_generic_tracer.F90intoconfig_src/external/GFDL_ocean_BGC. This change is made to allow the CI checks to pass - it has no other impact.In future release branches, the two commits in this PR should be squashed into: