Skip to content

Update parsers to allow updating list elements#41

Merged
micaeljtoliveira merged 1 commit intomainfrom
config_lists_updates
Feb 19, 2026
Merged

Update parsers to allow updating list elements#41
micaeljtoliveira merged 1 commit intomainfrom
config_lists_updates

Conversation

@micaeljtoliveira
Copy link
Copy Markdown
Member

Add a list subclass to handle updates of individual list elements in parsed config files.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9246d9d) to head (6b5926a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          431       451   +20     
=========================================
+ Hits           431       451   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micaeljtoliveira
Copy link
Copy Markdown
Member Author

@edoyango And here is another PR! Absolutely not urgent, so please review only when you have some time.

Copy link
Copy Markdown
Collaborator

@edoyango edoyango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

If we were dealing with large trees, converting value to a list should probably be avoided e.g. if it's a generator. But I doubt that will be an issue in the foreseeable future.

@micaeljtoliveira
Copy link
Copy Markdown
Member Author

@edoyango Thanks for having a look!

If we were dealing with large trees, converting value to a list should probably be avoided e.g. if it's a generator. But I doubt that will be an issue in the foreseeable future.

Yes, that's true, but our config files should never hold lists large enough for this to be an issue I think. Otherwise simply parsing those files will be very slow with the current code.

@micaeljtoliveira micaeljtoliveira merged commit 2a00685 into main Feb 19, 2026
8 checks passed
@micaeljtoliveira micaeljtoliveira deleted the config_lists_updates branch February 19, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants