Update parsers to allow updating list elements#41
Conversation
…parsed config files.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 431 451 +20
=========================================
+ Hits 431 451 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@edoyango And here is another PR! Absolutely not urgent, so please review only when you have some time. |
edoyango
left a comment
There was a problem hiding this comment.
LGTM!
If we were dealing with large trees, converting value to a list should probably be avoided e.g. if it's a generator. But I doubt that will be an issue in the foreseeable future.
|
@edoyango Thanks for having a look!
Yes, that's true, but our config files should never hold lists large enough for this to be an issue I think. Otherwise simply parsing those files will be very slow with the current code. |
Add a list subclass to handle updates of individual list elements in parsed config files.