Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
- Coverage 91.78% 91.51% -0.28%
==========================================
Files 15 18 +3
Lines 475 554 +79
Branches 96 112 +16
==========================================
+ Hits 436 507 +71
- Misses 18 25 +7
- Partials 21 22 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
14dea3f to
3902f5e
Compare
|
Hi @aekiss can you review this PR related to the om2 forcing perturbation? |
707c5ce to
16efb4b
Compare
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
|
Thanks @minghangli-uni - apart from the required temporal, spatial order for separable I didn't spot any other problems. I'm not a good person to review python code though, and only scanned over it. |
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
|
Thanks @aekiss for your review. They look great! I've addressed your comments and suggestions. Could you have another look? |
aekiss
left a comment
There was a problem hiding this comment.
LGTM, thanks @minghangli-uni
|
not sure why you've got test fails though... |
|
The coverage dropped because I added another json parser to the |
|
The best way to resolve this is to add tests for the added code. If there's a reason not to do this, you could either skip this file from the codecov, or just merge with the reduced coverage |
How can I skip this file? |
|
I've added a |
closes #19
_extract_run_specific_paramsinsrc/experiment_generator/om2_forcing_updater.py