Skip to content

support om2 forcing file#20

Merged
minghangli-uni merged 19 commits intomainfrom
19-add-supoort-om2-forcing
Aug 26, 2025
Merged

support om2 forcing file#20
minghangli-uni merged 19 commits intomainfrom
19-add-supoort-om2-forcing

Conversation

@minghangli-uni
Copy link
Copy Markdown
Collaborator

@minghangli-uni minghangli-uni commented Aug 12, 2025

closes #19

  • Add a parser to parse json-format file,
  • Add an updater for the om2 forcing configuration,
  • Add more logic to _extract_run_specific_params in src/experiment_generator/om2_forcing_updater.py
  • unittest

@minghangli-uni minghangli-uni self-assigned this Aug 12, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 89.53488% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.51%. Comparing base (21aef2e) to head (8e79c99).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/experiment_generator/tmp_parser/json_parser.py 36.36% 7 Missing ⚠️
src/experiment_generator/om2_forcing_updater.py 98.43% 0 Missing and 1 partial ⚠️
...rc/experiment_generator/perturbation_experiment.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   91.78%   91.51%   -0.28%     
==========================================
  Files          15       18       +3     
  Lines         475      554      +79     
  Branches       96      112      +16     
==========================================
+ Hits          436      507      +71     
- Misses         18       25       +7     
- Partials       21       22       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@minghangli-uni
Copy link
Copy Markdown
Collaborator Author

Hi @aekiss can you review this PR related to the om2 forcing perturbation?

@minghangli-uni minghangli-uni force-pushed the 19-add-supoort-om2-forcing branch from 707c5ce to 16efb4b Compare August 23, 2025 01:08
@minghangli-uni minghangli-uni requested a review from aekiss August 24, 2025 23:18
minghangli-uni and others added 2 commits August 26, 2025 10:38
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
@aekiss
Copy link
Copy Markdown
Contributor

aekiss commented Aug 26, 2025

Thanks @minghangli-uni - apart from the required temporal, spatial order for separable I didn't spot any other problems. I'm not a good person to review python code though, and only scanned over it.

minghangli-uni and others added 2 commits August 26, 2025 11:02
Co-authored-by: Andrew Kiss <31054815+aekiss@users.noreply.github.com>
@minghangli-uni
Copy link
Copy Markdown
Collaborator Author

Thanks @aekiss for your review. They look great! I've addressed your comments and suggestions. Could you have another look?

Copy link
Copy Markdown
Contributor

@aekiss aekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @minghangli-uni

@aekiss
Copy link
Copy Markdown
Contributor

aekiss commented Aug 26, 2025

not sure why you've got test fails though...

@minghangli-uni
Copy link
Copy Markdown
Collaborator Author

The coverage dropped because I added another json parser to the tmp_parser. That’s expected and it’s fine for now since all the parsers will eventually be replaced.

@dougiesquire
Copy link
Copy Markdown
Collaborator

The best way to resolve this is to add tests for the added code. If there's a reason not to do this, you could either skip this file from the codecov, or just merge with the reduced coverage

@minghangli-uni
Copy link
Copy Markdown
Collaborator Author

skip this file from the codecov

How can I skip this file?

@minghangli-uni
Copy link
Copy Markdown
Collaborator Author

I've added a codecov.yml file. The files in tmp_parser are still not being ignored, and I’m not sure if it will start working once this is merged into the main branch. I'll bypass rules and merge this to see if works.

 ignore:
   # https://docs.codecov.com/docs/ignoring-paths
   - "src/experiment_generator/tmp_parser/**/*"

@minghangli-uni minghangli-uni merged commit 0790d82 into main Aug 26, 2025
6 of 8 checks passed
@minghangli-uni minghangli-uni deleted the 19-add-supoort-om2-forcing branch August 26, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for om2 forcing.json

3 participants