Add ACCESSOM3Profiling to access_models.py#48
Draft
minghangli-uni wants to merge 2 commits intomainfrom
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
===========================================
- Coverage 100.00% 98.38% -1.62%
===========================================
Files 16 16
Lines 791 806 +15
===========================================
+ Hits 791 793 +2
- Misses 0 13 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@minghangli-uni Are you planning on adding here support for ESMF traces or will you include that later? |
Collaborator
Author
|
Oops, sorry I've just seen this. Yes, I'm planning to implement |
0c38089 to
58b645d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #47
closes #55
Before this PR, parts of the scaling and perturbation logic reflected esm1.6 assumptions but this is hard to add or modify support for another model, say ACCESS-OM3. So this PR not only adds supports for access-om3 configs but refactors the PayuManager into an orchestrator layer only.
Now PayuManager coordinates a generic sequence - for each requested node count, it builds model-specific layout search configuration, then requests layouts from the model adaptor (ie ACCESSOM3Profiling), then constructs a perturbation block per layout via a model-defined builder and finally passes the resulting blocks to the experiment-generator layer.
So now PayuManager no longer encodes any model layout structure.
EDIT: This update breaks the existing ESM1.6 workflow. We need adjustments to bring esm1.6 adaptor into alignment with the new interface, likely in a followed-up PR.