Skip to content

Add ACCESSOM3Profiling to access_models.py#48

Draft
minghangli-uni wants to merge 2 commits intomainfrom
47-om3-profiling
Draft

Add ACCESSOM3Profiling to access_models.py#48
minghangli-uni wants to merge 2 commits intomainfrom
47-om3-profiling

Conversation

@minghangli-uni
Copy link
Copy Markdown
Collaborator

@minghangli-uni minghangli-uni commented Feb 4, 2026

closes #47

closes #55

Before this PR, parts of the scaling and perturbation logic reflected esm1.6 assumptions but this is hard to add or modify support for another model, say ACCESS-OM3. So this PR not only adds supports for access-om3 configs but refactors the PayuManager into an orchestrator layer only.

Now PayuManager coordinates a generic sequence - for each requested node count, it builds model-specific layout search configuration, then requests layouts from the model adaptor (ie ACCESSOM3Profiling), then constructs a perturbation block per layout via a model-defined builder and finally passes the resulting blocks to the experiment-generator layer.

So now PayuManager no longer encodes any model layout structure.

EDIT: This update breaks the existing ESM1.6 workflow. We need adjustments to bring esm1.6 adaptor into alignment with the new interface, likely in a followed-up PR.

@minghangli-uni minghangli-uni self-assigned this Feb 4, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.38%. Comparing base (25e7fc6) to head (0c38089).

Files with missing lines Patch % Lines
src/access/profiling/access_models.py 13.33% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #48      +/-   ##
===========================================
- Coverage   100.00%   98.38%   -1.62%     
===========================================
  Files           16       16              
  Lines          791      806      +15     
===========================================
+ Hits           791      793       +2     
- Misses           0       13      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micaeljtoliveira
Copy link
Copy Markdown
Member

@minghangli-uni Are you planning on adding here support for ESMF traces or will you include that later?

@minghangli-uni
Copy link
Copy Markdown
Collaborator Author

Oops, sorry I've just seen this. Yes, I'm planning to implement esmf-trace here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generalise profiling workflow to support multiple model configs Add support for ACCESS-OM3 profiling

2 participants