Cherry-pick upstream commits from the develop branch for issm and petsc#8
Merged
harshula merged 3 commits intoreleases/v0.22from Jun 19, 2025
Merged
Cherry-pick upstream commits from the develop branch for issm and petsc#8harshula merged 3 commits intoreleases/v0.22from
harshula merged 3 commits intoreleases/v0.22from
Conversation
…l-lib' * Cherry-picked upstream commit 0a487df
Cherry-picked upstream commit bc662b8: * su2 fixes and improvements: AD, scipy/numpy, and Mutationpp setup, environment variable * su2: Conflict %gcc@13: when @:7, mpp was added with @7.1.0 * py-scipy: SciPy 1.14: requires GCC >= 9.1
* Cherry-picked upstream commit 0facf87
aidanheerdegen
approved these changes
Jun 19, 2025
Member
aidanheerdegen
left a comment
aidanheerdegen
left a comment
There was a problem hiding this comment.
LGTM. May as well leave the su2 changes in. They'll make it in eventually anyway, and they seem good, in that they're doing more checks and generally being more careful, so no harm and better to have them in case they will be used in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @aidanheerdegen , I'm happy to drop the changes to the
su2SPR since @justinh2002 probably doesn't need them. I've only include them because they were in the original upstream commit bc662b8 .@justinh2002 has provided some testing in:
Issue #5
Issue #6