Do not delete the proxy job if a new job was not created#189
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Do not delete the proxy job if a new job was not created#189copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
If a user calls connect with a proxy name that already exists, the script might fail and __exit__ will run on exiting context manager, thereby deleting the proxy job. This is incorrect since the script did not create a proxy job but deleted the job that a different process was already using. This commit fixes the behavior to not delete the pre-existing proxy. PiperOrigin-RevId: 875548702
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not delete the proxy job if a new job was not created
If a user calls connect with a proxy name that already exists, the script might fail and exit will run on exiting context manager, thereby deleting the proxy job. This is incorrect since the script did not create a proxy job but deleted the job that a different process was already using. This commit fixes the behavior to not delete the pre-existing proxy.