Use tenant-scoped dubbed-audio paths with traversal-safe resolution#454
Open
Use tenant-scoped dubbed-audio paths with traversal-safe resolution#454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DUBBED_AUDIO_DIRwith the same tenant-first media layout used for podcast audio/video so outputs live under each user workspace.Description
_get_dubbed_audio_dir(user_id, *, ensure_exists=False)to resolve per-tenantdubbed_audiodirectories under the podcast audio workspace and create them when required._resolve_dubbed_audio_file(filename, user_id)which searches tenant directories first, falls back to the legacydata/media/dubbed_audiopath, and enforces traversal-safe checks before returning a file path.DUBBED_AUDIO_DIRby initializingAudioDubbingService(output_dir=...)with the tenant-specific directory and by serving files via_resolve_dubbed_audio_file(...)in/dub/audio/{filename}and/dub/voices/audio/{filename}handlers.data/media/dubbed_audiodirectory as a final fallback read location.Testing
python -m py_compile backend/api/podcast/handlers/dubbing.py, which succeeded.Codex Task