configurable masks color and default brush color#12326
Merged
AUTOMATIC1111 merged 1 commit intodevfrom Aug 5, 2023
Merged
Conversation
Owner
|
It's a great idea but turn those zeros into ones. Also use |
AUTOMATIC1111
approved these changes
Aug 5, 2023
1 task
Closed
|
Is there a way to turn off the transparency? I use auto1111 with cloud-inference and that only works with the default JPEG format, so the transparent mask completely broke Inpainting for Cloud Inference. |
Collaborator
Author
@MaxMagnos |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oh my eyes my eyes
I'm blinded by the Light
Description
682ff89 I know you're overjoyed
but at least make it consistent and configurable
the default brush color for the color sketch is not important, as we have a
color pickerbuilt into the toolbut since you changed it on
Inpaint sketchand not forsketchI decide to annoy you to put all three options inunfortunately I don't think there is a
color pickeron the noirmalsketchtool (only on thecolor-sketch)so we cannot change the mask brush color during use
and the mask color is not updated by the settings immediately and requires a Reload
maybe it's achievable if we do some messing around with JavaScript
able to change the transparent mask color is important
as depending on what images you're working on some mask color may not be suited
Screenshots/videos:
before pr
2023-08-05.08_44_11_043.chrome.mp4
after PR

Checklist: