Finer settings freezing control#13789
Merged
AUTOMATIC1111 merged 4 commits intoAUTOMATIC1111:devfrom Jan 1, 2024
Merged
Conversation
Owner
|
you lost some settings/reverted some changes in modules/cmd_args.py. |
AUTOMATIC1111
approved these changes
Jan 1, 2024
AUTOMATIC1111
added a commit
that referenced
this pull request
Jan 1, 2024
Closed
Closed
ruchej
pushed a commit
to ruchej/stable-diffusion-webui
that referenced
this pull request
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have a use-case where I would like to control which settings users can change. I share my instance with friends whom I trust (hence no authentication issues) but I do not want them to accidentally change certain settings.
The --freeze-settings parameter is not suitable because there are some settings which they should be able to change (such as the currently used checkpoint), and the --hide-ui-dir-config is only applicable for a small subset of settings (plus this setting as HIDES the settings completely, which I do not necessarily want to do.
The solution I suggest (and have implemented so far) is:
The changes to the code add the two new options to the known commands list (in modules/cmd_args.py) and add additional assertions when setting new settings (in the same way as --freeze-settings does)
Example options for testing:
--freeze-settings-in-sections API,system --freeze-specific-settings samples_save
Screenshots/videos:
Checklist: