Skip to content

dir buttons start with / so only the correct dir will be shown and no…#13957

Merged
AUTOMATIC1111 merged 3 commits intoAUTOMATIC1111:devfrom
h43lb1t0:extra_network_subdirs
Dec 2, 2023
Merged

dir buttons start with / so only the correct dir will be shown and no…#13957
AUTOMATIC1111 merged 3 commits intoAUTOMATIC1111:devfrom
h43lb1t0:extra_network_subdirs

Conversation

@h43lb1t0
Copy link
Contributor

Description

  • fixed [Bug]: Lora folders get mixed #13895
    when show dirs is selected, a / is not only inserted after the folder name, but also before it. so that only the selected folder is actually displayed, and not also other folders whose name is a substring of the selected folder.

Screenshots/videos:

image

Checklist:

…t dirs with a substrings as name from the dir
@AUTOMATIC1111
Copy link
Owner

The reason for using them without a slash is to make it possible to create dirs that server as keywords for search and this change would make them not work.

@h43lb1t0
Copy link
Contributor Author

Okay. What about a setting for this with the current behavior as default?

@AUTOMATIC1111
Copy link
Owner

That would be fine.

@h43lb1t0
Copy link
Contributor Author

I have added a setting for this. I hope the description in the setting is understandable, but I am of course open to suggestions for improvement.

@AUTOMATIC1111 AUTOMATIC1111 merged commit 0bb6e00 into AUTOMATIC1111:dev Dec 2, 2023
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants