Update devices.py - Make 'use-cpu all' actually apply to 'all'#14131
Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom Dec 2, 2023
Merged
Update devices.py - Make 'use-cpu all' actually apply to 'all'#14131AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
Conversation
fixes issue where "--use-cpu" all properly makes SD run on CPU but leaves ControlNet (and other extensions, I presume) pointed at GPU, causing a crash in ControlNet caused by a mismatch between devices between SD and CN AUTOMATIC1111#14097
AUTOMATIC1111
approved these changes
Dec 2, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes issue where "--use-cpu all" properly makes SD run on CPU but leaves ControlNet (and other extensions, I presume) pointed at GPU, causing a crash in ControlNet caused by a mismatch between devices between SD and CN. This change would make all calls to get_device_for(task) return cpu when using "--use-cpu all" as an argument. This is on the assumption that "all" is meant to point everything to the CPU but I might have misunderstood the intent of the argument.
Should fix #14097 and Mikubill/sd-webui-controlnet#2247
Screenshots/videos:
Checklist: