Skip to content

Fix logging configuration again#14538

Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
akx:log-wut
Jan 5, 2024
Merged

Fix logging configuration again#14538
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
akx:log-wut

Conversation

@akx
Copy link
Collaborator

@akx akx commented Jan 4, 2024

Description

Post #13996, debug logging wouldn't work correctly. This makes it work correctly, and then some:

  • Only use tqdm.write() if tqdm is active, defer to stderr
  • Correct log formatter for TqdmLoggingHandler
  • If rich is installed and SD_WEBUI_RICH_LOG is set, use rich's formatter.

Screenshots/videos:

The rich log can look like

Screenshot 2024-01-04 at 19 33 47

Checklist:

* Only use `tqdm.write()` if `tqdm` is active, defer to stderr
* Correct log formatter for TqdmLoggingHandler
* If `rich` is installed and `SD_WEBUI_RICH_LOG` is set, use `rich`'s formatter
@akx akx requested a review from AUTOMATIC1111 as a code owner January 4, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants